Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 151010: A quick fix for Issue 15531 and 10953... (Closed)

Created:
11 years, 5 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

A quick fix for Issue 15531 and 10953 This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent(). Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object. Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus. BUG=10953 "IME support" BUG=15531 "regression: shift-space doesn't scroll the page backwards" TEST=Open a test page in <http://crbug.com/15531>;, press shift+space keys, and observe ev.shiftKey is true. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19707

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 6 chunks +25 lines, -8 lines 0 comments Download
M chrome/common/native_web_keyboard_event.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/native_web_keyboard_event_linux.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/api/public/gtk/WebInputEventFactory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/api/src/gtk/WebInputEventFactory.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
11 years, 5 months ago (2009-06-29 07:24:27 UTC) #1
Hironori Bono
To fix compatibility problems with IMEs (such as ibus), I have added a gtk_im_context_focus_in() call ...
11 years, 5 months ago (2009-06-29 09:57:47 UTC) #2
Evan Martin
LGTM
11 years, 5 months ago (2009-06-29 14:45:48 UTC) #3
Evan Stade
11 years, 5 months ago (2009-06-29 17:29:56 UTC) #4
lg

http://codereview.chromium.org/151010/diff/17/1007
File chrome/browser/renderer_host/render_widget_host_view_gtk.cc (right):

http://codereview.chromium.org/151010/diff/17/1007#newcode191
Line 191: // Notify this focus-in event to the GtkIMContext object and
nit: "Notify the GtkIMContext object of this focus-in event" (here and below)

Powered by Google App Engine
This is Rietveld 408576698