Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1510083003: [cleanup] Introduce HasEnumerableElements() helper (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Introduce HasEnumerableElements() helper This is a simplified copy of JSObject::GetOwnElementKeys and will make it possible to eliminate the latter. Committed: https://crrev.com/8ee1c9b5c0531f3c167697f5f0f9a0670fb2a83a Cr-Commit-Position: refs/heads/master@{#32713}

Patch Set 1 #

Patch Set 2 : added TODO as discussed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -8 lines) Patch
M src/objects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.cc View 1 3 chunks +62 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
Next step towards eliminating all of GetKeys()' predecessors.
5 years ago (2015-12-09 10:46:18 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-09 10:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510083003/20001
5 years ago (2015-12-09 12:24:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 13:17:00 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 13:17:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ee1c9b5c0531f3c167697f5f0f9a0670fb2a83a
Cr-Commit-Position: refs/heads/master@{#32713}

Powered by Google App Engine
This is Rietveld 408576698