Issue 1510043002: Improve comment in UnmodifiableListView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1510043002: Improve comment in UnmodifiableListView. (Closed)

Created:
5 years ago by floitsch

Modified:
5 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Improve comment in UnmodifiableListView. The class already states that the source must have efficient-length, but the constructor didn't reiterate this requirement. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/1a3853b128a4603effa4cc835dbc1654ea1239e4

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	sdk/lib/collection/collections.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

floitsch

5 years ago (2015-12-09 20:26:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1a3853b128a4603effa4cc835dbc1654ea1239e4 (presubmit successful).