Add an automatic settings reset banner.

chrome/browser/prefs/tracked/tracked_atomic_preference.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/tracked/tracked_atomic_preference.h"
 
 #include "base/values.h"
 #include "chrome/browser/prefs/pref_hash_store.h"
 
 TrackedAtomicPreference::TrackedAtomicPreference(
     const std::string& pref_path,
     size_t reporting_id,
     size_t reporting_ids_count,
     PrefHashFilter::EnforcementLevel enforcement_level,
     PrefHashStore* pref_hash_store)
     : pref_path_(pref_path),
       helper_(pref_path, reporting_id, reporting_ids_count, enforcement_level),
       pref_hash_store_(pref_hash_store) {
 }
 
 void TrackedAtomicPreference::OnNewValue(
     const base::Value* value) const {
   pref_hash_store_->StoreHash(pref_path_, value);
 }
 
-void TrackedAtomicPreference::EnforceAndReport(
+bool TrackedAtomicPreference::EnforceAndReport(
     base::DictionaryValue* pref_store_contents) const {
   const base::Value* value = NULL;
   pref_store_contents->Get(pref_path_, &value);
   PrefHashStore::ValueState value_state =
       pref_hash_store_->CheckValue(pref_path_, value);
 
   helper_.ReportValidationResult(value_state);
 
   TrackedPreferenceHelper::ResetAction reset_action =
       helper_.GetAction(value_state);
   helper_.ReportAction(reset_action);
 
-  if (reset_action == TrackedPreferenceHelper::DO_RESET)
+  bool was_reset = false;
+  if (reset_action == TrackedPreferenceHelper::DO_RESET) {
     pref_store_contents->RemovePath(pref_path_, NULL);
+    was_reset = true;
+  }
 
   if (value_state != PrefHashStore::UNCHANGED) {
     // Store the hash for the new value (whether it was reset or not).
     const base::Value* new_value = NULL;
     pref_store_contents->Get(pref_path_, &new_value);
     pref_hash_store_->StoreHash(pref_path_, new_value);
   }
+
+  return was_reset;

[erikwright (departed), 2014/02/06 20:04:03]

why not just return action == DO_RESET

[gab, 2014/02/06 20:40:11]

I'd argue that it's nicer to have |was_reset| because it keeps the fact that
reset means "action == DO_RESET" in a single place (otherwise; should this ever
change and the return value not also be fixed, we have a bug).

[erikwright (departed), 2014/02/06 20:51:57]

I don't mind either way.

[robertshield, 2014/02/07 04:36:19]

Mildest of preferences for as is for the reason Gab stated.

[robertshield, 2014/02/07 04:36:19]

Done.

[robertshield, 2014/02/07 04:36:19]

Done.

 }