Add an automatic settings reset banner.

chrome/browser/ui/webui/options/automatic_settings_reset_handler.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/options/automatic_settings_reset_handler.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/prefs/pref_service.h"
+#include "base/time/time.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
+#include "content/public/browser/web_ui.h"
+#include "grit/generated_resources.h"
+
+namespace {
+const int kBannerShowTimeInDays = 5;
+}
+
+namespace options {
+
+AutomaticSettingsResetHandler::AutomaticSettingsResetHandler() {}
+AutomaticSettingsResetHandler::~AutomaticSettingsResetHandler() {}
+
+void AutomaticSettingsResetHandler::InitializePage() {

[gab, 2014/02/05 15:23:52]

Log UMA stat about impression of this UI?

[robertshield, 2014/02/06 18:56:50]

Already done. See JS file.

+  PrefService* local_state = g_browser_process->local_state();

[gab, 2014/02/05 15:23:52]

const (or simply inline the call since you only need local_state once)

[robertshield, 2014/02/06 18:56:50]

Done.

+  int64 reset_time =
+      local_state->GetInt64(prefs::kProfilePreferenceResetTime);
+  if (reset_time != 0) {
+    base::Time now = base::Time::Now();

[gab, 2014/02/05 15:23:52]

const

[robertshield, 2014/02/06 18:56:50]

Done.

+    base::Time then = base::Time::FromInternalValue(reset_time);

[gab, 2014/02/05 15:23:52]

const

[robertshield, 2014/02/06 18:56:50]

Done.

+    if ((now - then).InDays() < kBannerShowTimeInDays) {
+      web_ui()->CallJavascriptFunction("AutomaticSettingsResetBanner.show");
+    }

[gab, 2014/02/05 15:23:52]

remove {}

[robertshield, 2014/02/06 18:56:50]

Done.

+  }
+}
+
+void AutomaticSettingsResetHandler::GetLocalizedValues(
+    base::DictionaryValue* localized_strings) {
+  DCHECK(localized_strings);
+
+  static OptionsStringResource resources[] = {

[gab, 2014/02/05 15:23:52]

static const

[robertshield, 2014/02/06 18:56:50]

Done.

+    { "automaticSettingsResetBannerText",
+        IDS_AUTOMATIC_SETTINGS_RESET_BANNER_TEXT },

[gab, 2014/02/05 15:23:52]

Align flush with string above (same below); e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[robertshield, 2014/02/06 18:56:50]

Done.

+    { "automaticSettingsResetLearnMoreUrl",
+        IDS_AUTOMATIC_SETTINGS_RESET_LINK_LEARN_MORE },
+  };
+
+  RegisterStrings(localized_strings, resources, arraysize(resources));
+  localized_strings->SetString(
+      "automaticSettingsResetLearnMoreUrl",
+      chrome::kAutomaticSettingsResetLearnMoreURL);
+}
+
+void AutomaticSettingsResetHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback("onDismissedAutomaticSettingsResetBanner",
+      base::Bind(&AutomaticSettingsResetHandler::
+                 OnDismissedAutomaticSettingsResetBanner,

[gab, 2014/02/05 15:23:52]

This is a continuation of the above method name; either indent 4 spaces from
here; or preferably, indent all the arguments 4 spaces on the next line after
"base::Bind(" if this makes this one fit on a single line

[robertshield, 2014/02/06 18:56:50]

Done.

+                 base::Unretained(this)));

[gab, 2014/02/05 15:23:52]

This depends on the lifetime of this handler (which I think is bound to the
lifetime of the OptionsUI -- this could cause a crash if the settings page is
closed before this callback is called I think. 

Instead make OnDismissedAutomaticSettingsResetBanner() an anonymous method (it
doesn't need any class data anyways); the callback will then be forever valid
(as long as g_browser_process != NULL but I feel g_browser_process must be reset
way after the browser is done pumping tasks).

[robertshield, 2014/02/06 18:56:50]

A nicer way is to use a weak ptr, which this was meant to do but I typo'd.
Sorry. 

[gab, 2014/02/06 20:40:11]

The weak ptr is not nicer than an anonymous method when possible IMO; the
WeakPtr makes it such that if this is deleted, your callback won't be called.

In this specific case it means that if the OptionsBlah object owning this goes
away (chrome://settings is closed?) before you callback, you never get it.

Ideally I think if the user X's out the banner and quickly close the settings
tab. Even if your callback is called later it should still be able to set the
pref (no reason it should require this UI handler to still be up).

[robertshield, 2014/02/07 04:36:19]

Done.

+}
+
+void AutomaticSettingsResetHandler::OnDismissedAutomaticSettingsResetBanner(
+    const base::ListValue* value) {

[gab, 2014/02/05 15:23:52]

Log UMA stat here?

How would we log UMA for UI only events (i.e. clicking Learn More)?

[robertshield, 2014/02/06 18:56:50]

This is already logged via user action counts. See JS file for implementation.

+  PrefService* local_state = g_browser_process->local_state();
+  local_state->ClearPref(prefs::kProfilePreferenceResetTime);
+}
+
+}  // namespace options