chrome/browser/resources/options/automatic_settings_reset_banner.html - Issue 151003004: Add an automatic settings reset banner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/automatic_settings_reset_banner.html

Issue 151003004: Add an automatic settings reset banner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pre-review cleanup. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <div id="automatic-settings-reset-banner" hidden>

	2 <div id="automatic-settings-reset-banner-close" class="close-button"></div>

	3 <div class="content-area">

	4 <div class="badge"></div>

	5 <div class="text">

	6 <p>

	7 <span i18n-values=".innerHTML:automaticSettingsResetBannerText">

	8 </span>
	gab 2014/02/05 15:23:52 Should that span just use the <span i18n-values=" Should that span just use the <span i18n-values="..." /> syntax? Or does our style prefer always having an explicit open/close scope for HTML tags? robertshield 2014/02/06 18:56:50 Quick search suggests the explicit scope is more c Show quoted text On 2014/02/05 15:23:52, gab wrote: > Should that span just use the > > <span i18n-values="..." /> > > syntax? Or does our style prefer always having an explicit open/close scope for > HTML tags? Quick search suggests the explicit scope is more common. http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml doesn't explicitly cover this case. I'll leave it as is.
	9 <a id="automatic-settings-reset-learn-more" class="nowrap"

	10 i18n-values="href:automaticSettingsResetLearnMoreUrl"

	11 i18n-content="learnMore" target="_blank"></a>
	gab 2014/02/05 15:23:52 Same question about this <a> tag. Same question about this <a> tag. robertshield 2014/02/06 18:56:50 Same answer. Show quoted text On 2014/02/05 15:23:52, gab wrote: > Same question about this <a> tag. Same answer.
	12 </p>

	13 </div>

	14 </div>

	15 </div>

OLD	NEW