GTTF: Enable tcmalloc's debugallocation on Windows.

GTTF: Enable tcmalloc's debugallocation on Windows.

BUG=30715
R=jar@chromium.org, rtenneti@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200327

[ramant (doing other things), 2013-05-10 23:21:58]

LGTM. Would be great to get approval from jar@.

[jar (doing other things), 2013-05-13 00:29:01]

I don't know what the G T T F means.
This doesnt' really enable tcmalloc's debug allocation, so much as perhaps it
makes it possible to enable it... or am I misunderstanding the change?

[Paweł Hajdan Jr., 2013-05-13 16:56:23]

On 2013/05/13 00:29:01, jar wrote:
> I don't know what the G T T F means.

Green Tree Task Force

> This doesnt' really enable tcmalloc's debug allocation,

Why do you think so? Please take a look at the linked bug and
debugallocation_shim.cc

[jar (doing other things), 2013-05-15 00:56:14]

https://codereview.chromium.org/15100010/diff/1/third_party/tcmalloc/chromium...
File third_party/tcmalloc/chromium/src/debugallocation.cc (right):

https://codereview.chromium.org/15100010/diff/1/third_party/tcmalloc/chromium...
third_party/tcmalloc/chromium/src/debugallocation.cc:73: #include
"base/compiler_specific.h"
per discussion: kill this line, and then use an ifdef for the static declaration
below (don't bother with the error checking on Windows)... and our port will be
a bit less confusing (since this base include is not the same as the other base
include)

[Paweł Hajdan Jr., 2013-05-15 17:59:45]

https://codereview.chromium.org/15100010/diff/1/third_party/tcmalloc/chromium...
File third_party/tcmalloc/chromium/src/debugallocation.cc (right):

https://codereview.chromium.org/15100010/diff/1/third_party/tcmalloc/chromium...
third_party/tcmalloc/chromium/src/debugallocation.cc:73: #include
"base/compiler_specific.h"
On 2013/05/15 00:56:14, jar wrote:
> per discussion: kill this line, and then use an ifdef for the static
declaration
> below (don't bother with the error checking on Windows)... and our port will
be
> a bit less confusing (since this base include is not the same as the other
base
> include)

Done.

[jar (doing other things), 2013-05-15 18:35:28]

lgtm

[Paweł Hajdan Jr., 2013-05-15 19:01:16]

Committed patchset #2 manually as r200327 (presubmit successful).