Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 15100009: Let gyp create ninja files by default on linux. (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Let gyp create ninja files by default on linux. If a generator is set explicitly (via GYP_GENERATORS or via -f or via chromium.gyp_env), it will have precedence over the new default. If you've used make until now, run `ninja -C out/Debug` instead of `make` to build. If you're using goma, go/ma has documentation on how to use goma with ninja. (It's the same as make, except that CC / CXX are now picked up at `gclient sync` / `gclient runhooks` / `build/gyp_chromium` time instead of at build time.) If you can't use ninja for some reason, `export GYP_GENERATORS=make` and sync again. Please also send me (thakis@chromium.org) an email explaining why ninja does not work for you. This will also switch all bots that don't explicitly set a build tool (including the public bots). compile.py will use ninja instead or make based on if build.ninja or Makefile are newer, so they should build the right thing automatically. And since built products end up in the same place, packaging should do the right thing too. BUG=239257 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/gyp_chromium View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 7 months ago (2013-05-10 22:30:23 UTC) #1
Mark Mentovai
LGTM
7 years, 7 months ago (2013-05-10 22:31:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/15100009/1
7 years, 7 months ago (2013-05-11 03:03:59 UTC) #3
Nico
7 years, 7 months ago (2013-05-11 03:20:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r199603.

Powered by Google App Engine
This is Rietveld 408576698