Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 1509923002: Implement native web notifications for mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/notifications/notification_ui_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/message_center_notification_manager.cc
diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc
index b09d1826bf8e81dff258451aec3c5417843ad7fe..06ed30bca027efc0fe4a1f71e103415b94806ffa 100644
--- a/chrome/browser/notifications/message_center_notification_manager.cc
+++ b/chrome/browser/notifications/message_center_notification_manager.cc
@@ -43,6 +43,16 @@
#include "ash/system/web_notification/web_notification_tray.h"
#endif
+// Mac does support native notifications and defines this method
+// in notification_ui_manager_mac.mm
+#if !defined(OS_MACOSX)
+// static
+NotificationUIManager*
+NotificationUIManager::CreateNativeNotificationManager() {
+ return nullptr;
+}
+#endif
+
MessageCenterNotificationManager::MessageCenterNotificationManager(
message_center::MessageCenter* message_center,
scoped_ptr<message_center::NotifierSettingsProvider> settings_provider)
@@ -50,8 +60,7 @@ MessageCenterNotificationManager::MessageCenterNotificationManager(
settings_provider_(std::move(settings_provider)),
system_observer_(this),
stats_collector_(message_center),
- google_now_stats_collector_(message_center)
-{
+ google_now_stats_collector_(message_center) {
message_center_->AddObserver(this);
message_center_->SetNotifierSettingsProvider(settings_provider_.get());
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/notifications/notification_ui_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698