chrome/browser/notifications/notification_ui_manager_android.cc - Issue 1509923002: Implement native web notifications for mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1509923002: Implement native web notifications for mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_ui_manager_android.cc

diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc

index cf2b78a5303651a56555b79d36aa80bef6a93436..3a234dc8cf2eeef103cc15eff2af527c2b7459f6 100644

--- a/chrome/browser/notifications/notification_ui_manager_android.cc

+++ b/chrome/browser/notifications/notification_ui_manager_android.cc

@@ -239,6 +239,12 @@ void NotificationUIManagerAndroid::CancelAll() {

NOTREACHED();

}

+// TODO(miguelg) Notifications in Android are actually native

+// need to generalize this.

+bool NotificationUIManagerAndroid::AcceptNativeNotifications() {

+ return false;

bool NotificationUIManagerAndroid::RegisterNotificationUIManager(JNIEnv* env) {

return RegisterNativesImpl(env);

}