Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1509853006:
Fix 'debugging on Android' android_gdb_app script. (Closed)
DescriptionFix 'debugging on Android' android_gdb_app script.
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:
./platform_tools/android/bin/android_gdb_app -d nexus_6
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1509853006
Committed: https://skia.googlesource.com/skia/+/419c37269f7d0786e9058c93003061ed8037a402
Patch Set 1 #Patch Set 2 : Update doc with optional parameters information. #
Total comments: 2
Messages
Total messages: 18 (6 generated)
Description was changed from ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: ========== to ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: ==========
aam@google.com changed reviewers: + scroggo@google.com
scroggo@google.com changed reviewers: + djsollen@google.com
Adding Derek. Should probably update documentation as well (in the site/ directory).
Description was changed from ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: ========== to ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1509853006 ==========
On 2015/12/09 22:54:13, scroggo wrote: > Adding Derek. Should probably update documentation as well (in the site/ > directory). Thanks for quick reply. Added quick reference to optional parameters you can pass to android_gdb_app.
lgtm https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... File platform_tools/android/bin/android_gdb_app (right): https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... platform_tools/android/bin/android_gdb_app:7: source $SCRIPT_DIR/android_setup.sh "$@" I don't think this line is necessary.
https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... File platform_tools/android/bin/android_gdb_app (right): https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... platform_tools/android/bin/android_gdb_app:7: source $SCRIPT_DIR/android_setup.sh "$@" > I don't think this line is necessary. If I comment this line out, I get === $ ./platform_tools/android/bin/android_gdb_app -d nexus_6 mkdir: cannot create directory ‘/android_gdb_tmp’: Permission denied Copying symbol files ./platform_tools/android/bin/android_gdb_app: line 32: adb_pull_if_needed: command not found ./platform_tools/android/bin/android_gdb_app: line 33: adb_pull_if_needed: command not found ./platform_tools/android/bin/android_gdb_app: line 34: adb_pull_if_needed: command not found ./platform_tools/android/bin/android_gdb_app: line 35: adb_pull_if_needed: command not found Pushing gdbserver... === it seems that this script relies on at least SKIA_OUT variable defined and exported by android_setup.sh:179.
On 2015/12/10 21:16:53, aam2 wrote: > https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... > File platform_tools/android/bin/android_gdb_app (right): > > https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... > platform_tools/android/bin/android_gdb_app:7: source > $SCRIPT_DIR/android_setup.sh "$@" > > I don't think this line is necessary. > > If I comment this line out, I get > === > $ ./platform_tools/android/bin/android_gdb_app -d nexus_6 > mkdir: cannot create directory ‘/android_gdb_tmp’: Permission denied > Copying symbol files > ./platform_tools/android/bin/android_gdb_app: line 32: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 33: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 34: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 35: adb_pull_if_needed: > command not found > Pushing gdbserver... > === > > it seems that this script relies on at least SKIA_OUT variable defined and > exported by android_setup.sh:179. thanks for the details. still lgtm
On 2015/12/10 21:16:53, aam2 wrote: > https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... > File platform_tools/android/bin/android_gdb_app (right): > > https://codereview.chromium.org/1509853006/diff/20001/platform_tools/android/... > platform_tools/android/bin/android_gdb_app:7: source > $SCRIPT_DIR/android_setup.sh "$@" > > I don't think this line is necessary. > > If I comment this line out, I get > === > $ ./platform_tools/android/bin/android_gdb_app -d nexus_6 > mkdir: cannot create directory ‘/android_gdb_tmp’: Permission denied > Copying symbol files > ./platform_tools/android/bin/android_gdb_app: line 32: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 33: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 34: adb_pull_if_needed: > command not found > ./platform_tools/android/bin/android_gdb_app: line 35: adb_pull_if_needed: > command not found > Pushing gdbserver... > === > > it seems that this script relies on at least SKIA_OUT variable defined and > exported by android_setup.sh:179. thanks for the details. still lgtm
Awesome. I can't land this myself, feel free to land it!
On 2015/12/10 21:48:33, aam2 wrote: > Awesome. > I can't land this myself, feel free to land it! You just need to check the checkbox labelled "Commit". I'll take care of it though :)
The CQ bit was checked by scroggo@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509853006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509853006/20001
Message was sent while issue was closed.
Description was changed from ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1509853006 ========== to ========== Fix 'debugging on Android' android_gdb_app script. 1) com.skia -> com.skia.sample_app 2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example: ./platform_tools/android/bin/android_gdb_app -d nexus_6 BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1509853006 Committed: https://skia.googlesource.com/skia/+/419c37269f7d0786e9058c93003061ed8037a402 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/419c37269f7d0786e9058c93003061ed8037a402
Message was sent while issue was closed.
On 2015/12/10 22:00:50, scroggo wrote: > On 2015/12/10 21:48:33, aam2 wrote: > > Awesome. > > I can't land this myself, feel free to land it! > > You just need to check the checkbox labelled "Commit". I'll take care of it > though :) Ah, interesting! I read "Non-Skia-committers" section in https://skia.org/dev/contrib/submit, and deduced that I won't be able commit: === If you don’t have committer rights in https://skia.googlesource.com/skia.git … first of all, thanks for submitting your patch! We really appreciate these submissions. Unfortunately, we don’t yet have a way for Skia committers to mark a patch as “approved” and thus allow non-committers to commit them. So instead, please ask a Skia committer to land your patch for you or land using the commit queue. === Thanks for landing it. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
