Remove checkForChildrenAdjacentRuleChanges.

third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/css/invalidation/StyleInvalidator.h"
 
 #include "core/css/invalidation/InvalidationSet.h"
 #include "core/dom/Document.h"
@@ skipping 147 matching lines @@
             m_invalidationEntries[index] = m_invalidationEntries.last();
             m_invalidationEntries.removeLast();
             continue;
         }
 
         const SiblingInvalidationSet& invalidationSet = *m_invalidationEntries[index].m_invalidationSet;
 
         if (invalidationSet.invalidatesElement(element)) {
             const DescendantInvalidationSet& descendants = invalidationSet.descendants();
             if (descendants.wholeSubtreeInvalid()) {
-                // Avoid directly setting SubtreeStyleChange on element, or ContainerNode::checkForChildrenAdjacentRuleChanges()
-                // may propagate the SubtreeStyleChange to our own siblings' subtrees.
-
-                for (Element* child = ElementTraversal::firstChild(element); child; child = ElementTraversal::nextSibling(*child)) {
-                    child->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::SiblingSelector));
-                }
+                element.setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::StyleInvalidator));
                 return true;
             }
 
             if (descendants.invalidatesSelf())
                 thisElementNeedsStyleRecalc = true;
 
             if (!descendants.isEmpty())
                 recursionData.pushInvalidationSet(descendants);
         }
 
@@ skipping 27 matching lines @@
     if (element.styleChangeType() >= SubtreeStyleChange || recursionData.wholeSubtreeInvalid()) {
         recursionData.setWholeSubtreeInvalid();
         return false;
     }
 
     bool thisElementNeedsStyleRecalc = recursionData.matchesCurrentInvalidationSets(element);
     if (UNLIKELY(!siblingData.isEmpty()))
         thisElementNeedsStyleRecalc |= siblingData.matchCurrentInvalidationSets(element, recursionData);
 
     if (UNLIKELY(element.needsStyleInvalidation()))
         pushInvalidationSetsForElement(element, recursionData, siblingData);

[rune, 2015/12/17 00:09:24]

Pushing sibling sets here must happen before the early return in this method.

[rune, 2015/12/17 12:55:00]

Done.

     return thisElementNeedsStyleRecalc;
 }
 
 bool StyleInvalidator::invalidateShadowRootChildren(Element& element, RecursionData& recursionData)
 {
     bool someChildrenNeedStyleRecalc = false;
     for (ShadowRoot* root = element.youngestShadowRoot(); root; root = root->olderShadowRoot()) {
         if (!recursionData.treeBoundaryCrossing() && !root->childNeedsStyleInvalidation() && !root->needsStyleInvalidation())
             continue;
         SiblingData siblingData;
@@ skipping 56 matching lines @@
 }
 
 DEFINE_TRACE(StyleInvalidator)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_pendingInvalidationMap);
 #endif
 }
 
 } // namespace blink