Support arguments and driver bug workarounds in command_buffer_gles2

gpu/gles2_conform_support/egl/egl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <EGL/egl.h>
 
 #include "base/command_line.h"
+#include "base/environment.h"
+#include "base/strings/string_split.h"
 #include "gpu/command_buffer/client/gles2_lib.h"
+#include "gpu/command_buffer/service/gpu_switches.h"
+#include "gpu/config/gpu_util.h"
 #include "gpu/gles2_conform_support/egl/display.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_surface.h"
 
 #if REGAL_STATIC_EGL
 extern "C" {
 
 typedef EGLContext RegalSystemContext;
 #define REGAL_DECL
 REGAL_DECL void RegalMakeCurrent( RegalSystemContext ctx );
@@ skipping 81 matching lines @@
   if (dpy == EGL_NO_DISPLAY)
     return EglError(EGL_BAD_DISPLAY, EGL_FALSE);
 
   egl::Display* display = static_cast<egl::Display*>(dpy);
   if (!display->Initialize())
     return EglError(EGL_NOT_INITIALIZED, EGL_FALSE);
 
   // eglInitialize can be called multiple times, prevent InitializeOneOff from
   // being called multiple times.
   if (gfx::GetGLImplementation() == gfx::kGLImplementationNone) {
-    int argc = 1;
-    const char* const argv[] = {"dummy"};
-    base::CommandLine::Init(argc, argv);
+    scoped_ptr<base::Environment> env(base::Environment::Create());
+    std::vector<std::string> args;
+    std::string env_args;
+    if (env->GetVar("CHROME_COMMAND_BUFFER_GLES2_ARGS", &env_args)) {
+      args = base::SplitString(env_args, " ", base::TRIM_WHITESPACE,
+                               base::SPLIT_WANT_NONEMPTY);
+    }
+    if (args.size() == 0) {

[hendrikw, 2015/12/17 18:39:18]

Nit:
 if (args.empty())

[Kimmo Kinnunen, 2015/12/18 08:07:05]

Done.

+      args.push_back("dummy");
+    }
+    scoped_ptr<const char* []> argv(new const char*[args.size()]);
+    for (size_t i = 0; i < args.size(); ++i) {

[hendrikw, 2015/12/17 18:39:18]

Nit:
range-for instead >>  for (auto& arg : args) ...

[Kimmo Kinnunen, 2015/12/18 08:07:05]

The index is used in the lhs of the assignment.

+      argv[i] = args[i].c_str();
+    }
+    base::CommandLine::Init(args.size(), argv.get());
+    base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+    if (!command_line->HasSwitch(switches::kDisableGpuDriverBugWorkarounds)) {
+      gpu::ApplyGpuDriverBugWorkarounds(command_line);
+    }
+
     gfx::GLSurface::InitializeOneOff();
   }
 
   *major = 1;
   *minor = 4;
   return EglSuccess(EGL_TRUE);
 }
 
 EGLAPI EGLBoolean EGLAPIENTRY eglTerminate(EGLDisplay dpy) {
   EGLint error_code = ValidateDisplay(dpy);
@@ skipping 308 matching lines @@
   return EGL_FALSE;
 }
 
 /* Now, define eglGetProcAddress using the generic function ptr. type */
 EGLAPI __eglMustCastToProperFunctionPointerType EGLAPIENTRY
 eglGetProcAddress(const char* procname) {
   return reinterpret_cast<__eglMustCastToProperFunctionPointerType>(
       gles2::GetGLFunctionPointer(procname));
 }
 }  // extern "C"