Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150983003: [Android] Share gesture types between Java and C++ (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
Ted C, boliu, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Share gesture types between Java and C++ Provide a generating template for gesture event type constants, shared between Java and C++. This eliminates some redundant code between the two, and should simplify future maintenance. BUG=339530 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250292

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase and test fix #

Patch Set 4 : Fix WebView #

Total comments: 2

Patch Set 5 : Really fix WebView #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -262 lines) Patch
M android_webview/Android.mk View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/all_webview.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 chunks +18 lines, -37 lines 0 comments Download
A content/browser/android/gesture_event_type.h View 1 chunk +19 lines, -0 lines 0 comments Download
A content/browser/android/gesture_event_type_list.h View 1 chunk +34 lines, -0 lines 0 comments Download
M content/content.gyp View 1 2 chunks +13 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 11 chunks +44 lines, -44 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 2 25 chunks +43 lines, -64 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/GestureEventType.template View 1 chunk +13 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 1 2 67 chunks +117 lines, -117 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
jdduke (slow)
tedchoc@: PTAL. That was simpler than I thought, thanks for the suggestion!
6 years, 10 months ago (2014-01-31 01:57:45 UTC) #1
jdduke (slow)
On 2014/01/31 01:57:45, jdduke wrote: > tedchoc@: PTAL. That was simpler than I thought, thanks ...
6 years, 10 months ago (2014-02-10 19:28:49 UTC) #2
Ted C
lgtm, my only thought is that this took way too long for me to review
6 years, 10 months ago (2014-02-10 19:31:06 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-10 19:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/150983003/60001
6 years, 10 months ago (2014-02-10 19:34:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 19:55:39 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49294
6 years, 10 months ago (2014-02-10 19:55:40 UTC) #7
jdduke (slow)
piman@: Owner review for content.gyp? Thanks.
6 years, 10 months ago (2014-02-10 20:23:40 UTC) #8
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-10 20:34:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/150983003/60001
6 years, 10 months ago (2014-02-10 20:36:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 22:09:15 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=46773
6 years, 10 months ago (2014-02-10 22:09:16 UTC) #12
jdduke (slow)
boliu@: Review for android_webview/Android.mk? Thanks.
6 years, 10 months ago (2014-02-10 22:17:53 UTC) #13
boliu
https://codereview.chromium.org/150983003/diff/470001/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/150983003/diff/470001/android_webview/Android.mk#newcode52 android_webview/Android.mk:52: # android_webview/all_webview.gyp Need to put gesture_event_type_java in all_webview.gyp too
6 years, 10 months ago (2014-02-10 22:21:49 UTC) #14
jdduke (slow)
https://codereview.chromium.org/150983003/diff/470001/android_webview/Android.mk File android_webview/Android.mk (right): https://codereview.chromium.org/150983003/diff/470001/android_webview/Android.mk#newcode52 android_webview/Android.mk:52: # android_webview/all_webview.gyp On 2014/02/10 22:21:49, boliu wrote: > Need ...
6 years, 10 months ago (2014-02-10 22:59:25 UTC) #15
boliu
lgtm
6 years, 10 months ago (2014-02-10 23:00:22 UTC) #16
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-10 23:06:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/150983003/540001
6 years, 10 months ago (2014-02-10 23:08:55 UTC) #18
piman
lgtm
6 years, 10 months ago (2014-02-10 23:27:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/150983003/540001
6 years, 10 months ago (2014-02-10 23:58:08 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 02:32:35 UTC) #21
Message was sent while issue was closed. 
Change committed as 250292

Powered by Google App Engine
This is Rietveld 408576698