Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 15098: Enables restoring of keyboard focus to the the toolbar button that last had f... (Closed)

Created:
12 years ago by Jonas Klink (Google)
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enables restoring of keyboard focus to the the toolbar button that last had focus, before focus was lost (e.g to a dialog, another window, etc). Setting focus using the toolbar focus keyboard shortcut will still reset focus to the first enabled, visible button (starting at the Back button). BUG=5750 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7620

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M chrome/browser/views/frame/browser_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 2 chunks +16 lines, -10 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Jonas Klink (Google)
12 years ago (2008-12-20 01:33:26 UTC) #1
jcampan
12 years ago (2008-12-20 02:20:11 UTC) #2
http://codereview.chromium.org/15098/diff/1/4
File chrome/browser/views/toolbar_view.cc (right):

http://codereview.chromium.org/15098/diff/1/4#newcode390
Line 390: }
I think I saw a case where the button was still showing as hot-tracked.
Shouldn't we unset the hot tracking on the acc_focused_view if any?

Powered by Google App Engine
This is Rietveld 408576698