Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1509783002: Revert of Remove invert viewport scroll order setting from Blink (Closed)

Created:
5 years ago by Lambros
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove invert viewport scroll order setting from Blink (patchset #3 id:40001 of https://codereview.chromium.org/1435233002/ ) Reason for revert: Speculatively reverting, as it might have caused compile failures: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/57888/steps/compile/logs/stdio ninja explain: output obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o older than most recent input ../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h (1449527421 vs 1449531710) ninja explain: obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o is dirty ninja explain: output obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o older than most recent input ../../out/Release/gen/blink/core/testing/InternalSettingsGenerated.h (1449527414 vs 1449531710) ninja explain: obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o is dirty ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty ninja explain: webkit_unit_tests is dirty ninja explain: obj/third_party/WebKit/public/all_blink.actions_depends.stamp is dirty ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty ninja explain: content_shell is dirty ninja explain: obj/build/blink_tests.actions_depends.stamp is dirty ninja explain: obj/third_party/WebKit/Source/core/libwebcore_testing.a is dirty [1/7] CXX obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8Internals.o [2/7] CXX obj/third_party/WebKit/Source/core/gen/blink/bindings/core/v8/webcore_testing.V8InternalSettings.o [3/7] AR obj/third_party/WebKit/Source/core/libwebcore_testing.a [4/7] LINK webkit_unit_tests [5/7] LINK content_shell [6/7] STAMP obj/third_party/WebKit/public/all_blink.actions_depends.stamp [7/7] STAMP obj/build/blink_tests.actions_depends.stamp Failing build because ninja reported work to do. This means that after completing a compile, another was run and it resulted in still having work to do (that is, a no-op build wasn't a no-op). Consult the first "ninja explain:" line for a likely culprit. Original issue's description: > Remove invert viewport scroll order setting from Blink > > Note: This setting was already removed on the Chromium side > in r348988 and set the Blink setting to always be true. This > patch just removes the now unused Blink branches. > > BUG=443724 > > Committed: https://crrev.com/82a9c12ebb952e773ee0db1f07aca6fb4d2b6dc9 > Cr-Commit-Position: refs/heads/master@{#363625} TBR=rbyers@chromium.org,avi@chromium.org,rjkroege@chromium.org,bokan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=443724 Committed: https://crrev.com/66b50ad278cb309e3ce24a3ce8eb317773f1e9e1 Cr-Commit-Position: refs/heads/master@{#363628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -35 lines) Patch
M components/html_viewer/blink_settings_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 2 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp View 4 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lambros
Created Revert of Remove invert viewport scroll order setting from Blink
5 years ago (2015-12-08 00:04:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509783002/1
5 years ago (2015-12-08 00:12:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 00:17:20 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-08 00:18:10 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66b50ad278cb309e3ce24a3ce8eb317773f1e9e1
Cr-Commit-Position: refs/heads/master@{#363628}

Powered by Google App Engine
This is Rietveld 408576698