Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1509773003: Minor image-related cleanups. (Closed)

Created:
5 years ago by Evan Stade
Modified:
5 years ago
Reviewers:
oshima, sadrul
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor image-related cleanups. - move throbber.png to make it more apparent how and where it's used. - after investigating the use of the panel frame images (can't delete them yet but it's not clear if they're worth vectorizing), improve the about:flags entry for --enable-panels. BUG=522168 TBR=sadrul@chromium.org Committed: https://crrev.com/3deb2182c687ec30b134585214e6c8658bb0b13d Cr-Commit-Position: refs/heads/master@{#364282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursors_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/resources/default_100_percent/common/pointers/throbber.png View Binary file 0 comments Download
D ui/resources/default_100_percent/throbber.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/pointers/throbber.png View Binary file 0 comments Download
D ui/resources/default_200_percent/throbber.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
Evan Stade
5 years ago (2015-12-08 01:50:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509773003/1
5 years ago (2015-12-08 20:07:34 UTC) #4
oshima
lgtm
5 years ago (2015-12-08 20:08:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509773003/1
5 years ago (2015-12-08 20:18:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/126596)
5 years ago (2015-12-08 20:30:18 UTC) #10
Evan Stade
tbr sadrul for ui/base/cursor/cursors_aura.cc (IDR_ resource name change)
5 years ago (2015-12-10 02:07:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509773003/1
5 years ago (2015-12-10 02:09:59 UTC) #15
sadrul
lgtm
5 years ago (2015-12-10 04:54:29 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 05:09:44 UTC) #18
commit-bot: I haz the power
5 years ago (2015-12-10 05:10:24 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3deb2182c687ec30b134585214e6c8658bb0b13d
Cr-Commit-Position: refs/heads/master@{#364282}

Powered by Google App Engine
This is Rietveld 408576698