Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1509733010: [es6] ship regexp sticky flag. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] ship regexp sticky flag. R=littledan@chromium.org BUG=v8:4342 LOG=Y Committed: https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 Cr-Commit-Position: refs/heads/master@{#32826}

Patch Set 1 #

Patch Set 2 : rebase and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/flag-definitions.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regexp-not-sticky-yet.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
5 years ago (2015-12-11 09:54:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509733010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509733010/1
5 years ago (2015-12-11 09:55:24 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12949)
5 years ago (2015-12-11 10:57:30 UTC) #5
Dan Ehrenberg
lgtm Looks good! Test failures seem to just be in Ignition, so I'd just disable ...
5 years ago (2015-12-11 19:04:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509733010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509733010/20001
5 years ago (2015-12-14 09:37:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 10:05:41 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 Cr-Commit-Position: refs/heads/master@{#32826}
5 years ago (2015-12-14 10:06:37 UTC) #12
Dan Ehrenberg
5 years ago (2015-12-16 20:59:04 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1531043002/ by littledan@chromium.org.

The reason for reverting is: This causes compatibility issues, as documented in
https://bugs.chromium.org/p/v8/issues/detail?id=4617#c9.

Powered by Google App Engine
This is Rietveld 408576698