Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 150973007: Exclude file_posix.cc from iOS build of net/ target (Closed)

Created:
6 years, 10 months ago by andrea
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, stuartmorgan, rohitrao (ping after 24h)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Exclude file_posix.cc from iOS build of net/ target Move the sources! section out of link_settings, where it was being ignored. BUG=330074 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
net/net.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
andrea
6 years, 10 months ago (2014-02-13 01:36:15 UTC) #1
rvargas (doing something else)
LGTM :(
6 years, 10 months ago (2014-02-13 02:02:58 UTC) #2
huey
The CQ bit was checked by huey@google.com
6 years, 10 months ago (2014-02-13 02:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huey@chromium.org/150973007/1
6 years, 10 months ago (2014-02-13 02:18:02 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 05:27:53 UTC) #5
Message was sent while issue was closed.
Change committed as 250961

Powered by Google App Engine
This is Rietveld 408576698