Fixes the rendering of a SVG filter (e.g. feFlood) by testing against total

Source/core/rendering/FilterEffectRenderer.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 48 matching lines @@
 
 static inline void lastMatrixRow(Vector<float>& parameters)
 {
     parameters.append(0);
     parameters.append(0);
     parameters.append(0);
     parameters.append(1);
     parameters.append(0);
 }
 
-inline bool isFilterSizeValid(FloatRect rect)
-{
-    if (rect.width() < 0 || rect.width() > kMaxFilterSize
-        || rect.height() < 0 || rect.height() > kMaxFilterSize)
-        return false;
-    return true;
-}
-
 FilterEffectRenderer::FilterEffectRenderer()
     : Filter(AffineTransform())
     , m_graphicsBufferAttached(false)
     , m_hasFilterThatMovesPixels(false)
     , m_hasCustomShaderFilter(false)
 {
     m_sourceGraphic = SourceGraphic::create(this);
 }
 
 FilterEffectRenderer::~FilterEffectRenderer()
@@ skipping 172 matching lines @@
     // If we didn't make any effects, tell our caller we are not valid
     if (!m_lastEffect.get())
         return false;
 
     return true;
 }
 
 bool FilterEffectRenderer::updateBackingStoreRect(const FloatRect& floatFilterRect)
 {
     IntRect filterRect = enclosingIntRect(floatFilterRect);
-    if (!filterRect.isEmpty() && isFilterSizeValid(filterRect)) {
+    if (!filterRect.isEmpty() && FilterEffect::isFilterSizeValid(filterRect)) {
         FloatRect currentSourceRect = sourceImageRect();
         if (filterRect != currentSourceRect) {
             setSourceImageRect(filterRect);
             return true;
         }
     }
     return false;
 }
 
 void FilterEffectRenderer::allocateBackingStoreIfNeeded()
@@ skipping 90 matching lines @@
 }
 
 GraphicsContext* FilterEffectRendererHelper::beginFilterEffect(GraphicsContext* oldContext)
 {
     ASSERT(m_renderLayer);
 
     FilterEffectRenderer* filter = m_renderLayer->filterRenderer();
     filter->allocateBackingStoreIfNeeded();
     // Paint into the context that represents the SourceGraphic of the filter.
     GraphicsContext* sourceGraphicsContext = filter->inputContext();
-    if (!sourceGraphicsContext || !isFilterSizeValid(filter->absoluteFilterRegion())) {
+    if (!sourceGraphicsContext || !FilterEffect::isFilterSizeValid(filter->absoluteFilterRegion())) {
         // Disable the filters and continue.
         m_haveFilterEffect = false;
         return oldContext;
     }
 
     m_savedGraphicsContext = oldContext;
 
     // Translate the context so that the contents of the layer is captuterd in the offscreen memory buffer.
     sourceGraphicsContext->save();
     // FIXME: can we just use sourceImageRect for everything, and get rid of
@@ skipping 17 matching lines @@
     // Get the filtered output and draw it in place.
     m_savedGraphicsContext->drawImageBuffer(filter->output(), filter->outputRect(), CompositeSourceOver);
 
     filter->clearIntermediateResults();
 
     return m_savedGraphicsContext;
 }
 
 } // namespace WebCore