Add a default share button to the menu of Custom Tabs

Add a default share button to the menu of Custom Tabs

There has been a demand from developers to implement an easy-to-add
share button in Custom Tabs' support library. This CL introduces a
boolean extra in CustomTabsIntent. Internally CustomTabActivity uses the
same method that every ChromeActivity use to share the current webpage.

BUG=561091
Committed: https://crrev.com/4f9db38a7f90dedf1fa9046b897cdb59ed7dfce8
Cr-Commit-Position: refs/heads/master@{#365791}

[Ian Wen, 2015-12-09 11:49:32]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org, yusufo@chromium.org

[Yusuf, 2015-12-09 18:49:28]

https://codereview.chromium.org/1509713004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1509713004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:258:
if (pendingIntent == null) {
Two questions here:

Should this be a default share "button" or a default share menu item? Probably
should discuss this on the bug.

Another one is if we are going to do a button, I think the boolean extra should
be another condition that is not tide to the action button related bits here. We
should check it inside the activity and handle it as its own thing and avoid
adding any other button. The logic with pendingIntent sometimes being null and
sometimes not complicates things unnecessarily imo.

[Ian Wen, 2015-12-14 14:03:25]

PTAL. :)

[Yusuf, 2015-12-16 07:40:05]

lgtm with a nit

https://codereview.chromium.org/1509713004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java
(right):

https://codereview.chromium.org/1509713004/diff/20001/chrome/android/java/src...
chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java:97:
public static final String EXTRA_DEFAULT_SHARE_BUTTON =
default share menu item similarly in other places as well.

https://codereview.chromium.org/1509713004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1509713004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:95:
private boolean mShowShareButton;
s/button/menuitem

[Ian Wen, 2015-12-16 07:59:32]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 07:59:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509713004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509713004/40001

[Ian Wen, 2015-12-16 08:00:55]

Thanks yusufo@ for the review!

newt@ would you mind taking a look at the trivial change in ChromeActivity?

[commit-bot: I haz the power, 2015-12-16 09:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 09:55:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[newt (away), 2015-12-16 19:08:54]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-12-16 19:08:55]

lgtm

[newt (away), 2015-12-16 19:08:55]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1509713004/#ps40001
(title: "rename button -> menu item")

[commit-bot: I haz the power, 2015-12-16 19:10:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509713004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509713004/40001

[commit-bot: I haz the power, 2015-12-16 20:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 20:58:31]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2015-12-17 07:24:07]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-12-17 07:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1509713004/#ps60001
(title: "Fix test")

[commit-bot: I haz the power, 2015-12-17 07:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509713004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509713004/60001

[commit-bot: I haz the power, 2015-12-17 07:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 07:28:14]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ian Wen, 2015-12-17 07:43:30]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 07:43:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509713004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509713004/60001

[commit-bot: I haz the power, 2015-12-17 07:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 07:46:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ian Wen, 2015-12-17 09:10:41]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-12-17 09:10:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
newt@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1509713004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-17 09:10:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509713004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509713004/80001

[commit-bot: I haz the power, 2015-12-17 09:47:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-17 09:48:37]

Description was changed from

==========
Add a default share button to the menu of Custom Tabs

There has been a demand from developers to implement an easy-to-add
share button in Custom Tabs' support library. This CL introduces a
boolean extra in CustomTabsIntent. Internally CustomTabActivity uses the
same method that every ChromeActivity use to share the current webpage.

BUG=561091
==========

to

==========
Add a default share button to the menu of Custom Tabs

There has been a demand from developers to implement an easy-to-add
share button in Custom Tabs' support library. This CL introduces a
boolean extra in CustomTabsIntent. Internally CustomTabActivity uses the
same method that every ChromeActivity use to share the current webpage.

BUG=561091

Committed: https://crrev.com/4f9db38a7f90dedf1fa9046b897cdb59ed7dfce8
Cr-Commit-Position: refs/heads/master@{#365791}
==========

[commit-bot: I haz the power, 2015-12-17 09:48:37]

Patchset 5 (id:??) landed as
https://crrev.com/4f9db38a7f90dedf1fa9046b897cdb59ed7dfce8
Cr-Commit-Position: refs/heads/master@{#365791}