Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: components/autofill/browser/autofill_manager.h

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2
Patch Set: rebased for IPC changes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_manager.h
diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h
index bac6bc709ce088ab8a363eb2f00be19518b1f071..54e3e13fb8821a6a9a8b4574af6ec74c918603fd 100644
--- a/components/autofill/browser/autofill_manager.h
+++ b/components/autofill/browser/autofill_manager.h
@@ -206,7 +206,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
}
// Processes the submitted |form|, saving any new Autofill data and uploading
- // the possible field types for the submitted fields to the crowdsouring
+ // the possible field types for the submitted fields to the crowdsourcing
// server. Returns false if this form is not relevant for Autofill.
bool OnFormSubmitted(const FormData& form,
const base::TimeTicks& timestamp);
@@ -345,7 +345,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
// The personal data manager, used to save and load personal data to/from the
// web database. This is overridden by the AutofillManagerTest.
// Weak reference.
- // May be NULL. NULL indicates OTR.
+ // May be NULL. NULL indicates OTR.
Ilya Sherman 2013/06/19 00:38:27 nit: Please revert the diff to this line.
sgurun-gerrit only 2013/06/19 17:56:23 Done.
PersonalDataManager* personal_data_;
std::list<std::string> autofilled_form_signatures_;
@@ -355,7 +355,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
scoped_ptr<AutofillDownloadManager> download_manager_;
// Handles single-field autocomplete form data.
- AutocompleteHistoryManager autocomplete_history_manager_;
+ scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
// Handles autocheckout flows.
autofill::AutocheckoutManager autocheckout_manager_;
@@ -421,7 +421,8 @@ class AutofillManager : public AutofillDownloadManager::Observer {
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
UserHappinessFormLoadAndSubmission);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
-
+ FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
+ FormSubmittedAutocompleteEnabled);
DISALLOW_COPY_AND_ASSIGN(AutofillManager);
};

Powered by Google App Engine
This is Rietveld 408576698