Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: components/autofill/browser/autocomplete_history_manager_unittest.cc

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2
Patch Set: rebased for IPC changes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autocomplete_history_manager_unittest.cc
diff --git a/components/autofill/browser/autocomplete_history_manager_unittest.cc b/components/autofill/browser/autocomplete_history_manager_unittest.cc
index 562b73fec55c844428ac6cab84e869254f8bc2f0..7391fae27a3c50aa5e64763d9fbb5804a917ae48 100644
--- a/components/autofill/browser/autocomplete_history_manager_unittest.cc
+++ b/components/autofill/browser/autocomplete_history_manager_unittest.cc
@@ -102,7 +102,8 @@ class AutocompleteHistoryManagerTest : public ChromeRenderViewHostTestHarness {
profile(), MockWebDataServiceWrapperCurrent::Build);
autofill_driver_.reset(new TestAutofillDriver(web_contents()));
autocomplete_manager_.reset(
- new AutocompleteHistoryManager(autofill_driver_.get()));
+ new AutocompleteHistoryManager(autofill_driver_.get(),
+ &manager_delegate));
}
virtual void TearDown() OVERRIDE {
@@ -224,8 +225,9 @@ class MockAutofillExternalDelegate : public AutofillExternalDelegate {
class AutocompleteHistoryManagerNoIPC : public AutocompleteHistoryManager {
public:
- explicit AutocompleteHistoryManagerNoIPC(AutofillDriver* driver)
- : AutocompleteHistoryManager(driver) {
+ explicit AutocompleteHistoryManagerNoIPC(AutofillDriver* driver,
Ilya Sherman 2013/06/19 00:38:27 nit: No longer a need for explicit here.
sgurun-gerrit only 2013/06/19 17:56:23 Done.
+ AutofillManagerDelegate* delegate)
+ : AutocompleteHistoryManager(driver, delegate) {
// Ensure that IPC is not sent during the test.
set_send_ipc(false);
}
@@ -238,7 +240,7 @@ class AutocompleteHistoryManagerNoIPC : public AutocompleteHistoryManager {
// Make sure our external delegate is called at the right time.
TEST_F(AutocompleteHistoryManagerTest, ExternalDelegate) {
AutocompleteHistoryManagerNoIPC autocomplete_history_manager(
- autofill_driver_.get());
+ autofill_driver_.get(), &manager_delegate);
scoped_ptr<AutofillManager> autofill_manager(new AutofillManager(
autofill_driver_.get(),

Powered by Google App Engine
This is Rietveld 408576698