Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: components/autofill/browser/autofill_manager.h

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2
Patch Set: enable autocomplete independent of autofill. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_manager.h
diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h
index d164923c8e55a68e89ceec4297020cdad2b7bb89..1dbfc7b677e8b658f5914663c6f307896e8e2d82 100644
--- a/components/autofill/browser/autofill_manager.h
+++ b/components/autofill/browser/autofill_manager.h
@@ -210,7 +210,7 @@ class AutofillManager : public content::WebContentsObserver,
}
// Processes the submitted |form|, saving any new Autofill data and uploading
- // the possible field types for the submitted fields to the crowdsouring
+ // the possible field types for the submitted fields to the crowdsourcing
// server. Returns false if this form is not relevant for Autofill.
bool OnFormSubmitted(const FormData& form,
const base::TimeTicks& timestamp);
@@ -234,6 +234,7 @@ class AutofillManager : public content::WebContentsObserver,
void OnFormsSeen(const std::vector<FormData>& forms,
const base::TimeTicks& timestamp,
autofill::FormsSeenState state);
+
void OnTextFieldDidChange(const FormData& form,
const FormFieldData& field,
const base::TimeTicks& timestamp);
@@ -244,6 +245,7 @@ class AutofillManager : public content::WebContentsObserver,
const FormFieldData& field,
const gfx::RectF& bounding_box,
bool display_warning);
+
void OnDidEndTextFieldEditing();
void OnHideAutofillUi();
void OnAddPasswordFormMapping(
@@ -350,7 +352,7 @@ class AutofillManager : public content::WebContentsObserver,
// The personal data manager, used to save and load personal data to/from the
// web database. This is overridden by the AutofillManagerTest.
// Weak reference.
- // May be NULL. NULL indicates OTR.
+ // May be NULL for OTR and Android Webview.
Ilya Sherman 2013/06/18 05:56:25 nit: Please revert all the changes in this file be
sgurun-gerrit only 2013/06/19 00:16:17 Done.
PersonalDataManager* personal_data_;
std::list<std::string> autofilled_form_signatures_;

Powered by Google App Engine
This is Rietveld 408576698