components/autofill/browser/autofill_manager_delegate.h - Issue 15097004: Enable Autocomplete feature for chromium webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autofill_manager_delegate.h

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2

Patch Set: added a unit test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/browser/autofill_manager.cc ('K') | « components/autofill/browser/autofill_manager.cc ('k') | components/autofill/browser/autofill_manager_unittest.cc » ('j') | components/autofill/browser/autofill_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/autofill_manager_delegate.h

diff --git a/components/autofill/browser/autofill_manager_delegate.h b/components/autofill/browser/autofill_manager_delegate.h

index 5563b9f9e716d68a2e2ae67a161ea88807c84cc2..5cf949ed2134ff3f965ec4d699e6265ff3a9294b 100644

--- a/components/autofill/browser/autofill_manager_delegate.h

+++ b/components/autofill/browser/autofill_manager_delegate.h

@@ -127,6 +127,9 @@ class AutofillManagerDelegate {

// Updates the Autocheckout progress bar. |value| must be in [0.0, 1.0].

virtual void UpdateProgressBar(double value) = 0;

+ // Whether the form data should be ignored.

+ virtual bool ShouldIgnoreFormData() = 0;

Ilya Sherman 2013/06/15 00:28:09 IMO this comment and method name are insufficientl

sgurun-gerrit only 2013/06/17 21:20:32 Himm, I guess a cleaner approach would be introduc

};

} // namespace autofill