Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 15097004: Enable Autocomplete feature for chromium webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setSaveFormData2
Patch Set: add a check that disappeared during a merge. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 0b8345ddfc438a970a5cd1748b14a666b5972071..92f5adf1d18c19da0137284c289939ab2bb5360c 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -139,7 +139,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
autofill::FormsSeenState state);
// Processes the submitted |form|, saving any new Autofill data and uploading
- // the possible field types for the submitted fields to the crowdsouring
+ // the possible field types for the submitted fields to the crowdsourcing
// server. Returns false if this form is not relevant for Autofill.
bool OnFormSubmitted(const FormData& form,
const base::TimeTicks& timestamp);
@@ -343,7 +343,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {
scoped_ptr<AutofillDownloadManager> download_manager_;
// Handles single-field autocomplete form data.
- AutocompleteHistoryManager autocomplete_history_manager_;
+ scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
// Handles autocheckout flows.
autofill::AutocheckoutManager autocheckout_manager_;
@@ -409,7 +409,8 @@ class AutofillManager : public AutofillDownloadManager::Observer {
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
UserHappinessFormLoadAndSubmission);
FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
-
+ FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
+ FormSubmittedAutocompleteEnabled);
DISALLOW_COPY_AND_ASSIGN(AutofillManager);
};

Powered by Google App Engine
This is Rietveld 408576698