Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 462 matching lines @@
                                                   int expected_page_id,
                                                   bool has_address_fields,
                                                   const char* year,
                                                   const char* month) {
   ExpectFilledForm(page_id, filled_form, expected_page_id,
                    "", "", "", "", "", "", "", "", "", "", "",
                    "Miku Hatsune", "4234567890654321", month, year,
                    has_address_fields, true, true);
 }
 
+class MockAutocompleteHistoryManager : public AutocompleteHistoryManager {
+ public:
+  MockAutocompleteHistoryManager(AutofillDriver* driver,
+                                 AutofillManagerDelegate* delegate)
+      : AutocompleteHistoryManager(driver, delegate) {}
+
+  MOCK_METHOD1(OnFormSubmitted, void(const FormData& form));
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockAutocompleteHistoryManager);
+};
+
 class TestAutofillManager : public AutofillManager {
  public:
   TestAutofillManager(AutofillDriver* driver,
                       autofill::AutofillManagerDelegate* delegate,
                       TestPersonalDataManager* personal_data)
       : AutofillManager(driver, delegate, personal_data),
         personal_data_(personal_data),
         autofill_enabled_(true) {}
   virtual ~TestAutofillManager() {}
 
@@ skipping 203 matching lines @@
                                                 false);
   }
 
   void GetAutofillSuggestions(const FormData& form,
                               const FormFieldData& field) {
     GetAutofillSuggestions(kDefaultPageID, form, field);
   }
 
   void AutocompleteSuggestionsReturned(
       const std::vector<base::string16>& result) {
-    autofill_manager_->autocomplete_history_manager_.SendSuggestions(&result);
+    autofill_manager_->autocomplete_history_manager_->SendSuggestions(&result);
   }
 
   void FormsSeen(const std::vector<FormData>& forms) {
     autofill_manager_->OnFormsSeen(forms, base::TimeTicks(),
                                    autofill::NO_SPECIAL_FORMS_SEEN);
   }
 
   void PartialFormsSeen(const std::vector<FormData>& forms) {
     autofill_manager_->OnFormsSeen(forms, base::TimeTicks(),
                                    autofill::PARTIAL_FORMS_SEEN);
@@ skipping 38 matching lines @@
       *page_id = autofill_param.a;
     if (values)
       *values = autofill_param.b;
     if (labels)
       *labels = autofill_param.c;
     if (icons)
       *icons = autofill_param.d;
     if (unique_ids)
       *unique_ids = autofill_param.e;
 
-    autofill_manager_->autocomplete_history_manager_.CancelPendingQuery();
+    autofill_manager_->autocomplete_history_manager_->CancelPendingQuery();
     process()->sink().ClearMessages();
     return true;
   }
 
   bool HasSeenAutofillGetAllFormsMessage() {
     const uint32 kMsgID = AutofillMsg_GetAllForms::ID;
     const IPC::Message* message =
         process()->sink().GetFirstMessageMatching(kMsgID);
     return message != NULL;
   }
@@ skipping 1926 matching lines @@
   FormData results;
   EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
   ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
 
   // Simulate form submission. We should call into the PDM to try to save the
   // filled data.
   EXPECT_CALL(personal_data_, SaveImportedProfile(::testing::_)).Times(1);
   FormSubmitted(results);
 }
 
+// Test that when Autocomplete is enabled and Autofill is disabled,
+// form submissions are still received by AutocompleteHistoryManager.
+TEST_F(AutofillManagerTest, FormSubmittedAutocompleteEnabled) {
+  TestAutofillManagerDelegate delegate;
+  autofill_manager_.reset(new TestAutofillManager(
+      autofill_driver_.get(),
+      &delegate,
+      NULL));
+  autofill_manager_->set_autofill_enabled(false);
+  scoped_ptr<MockAutocompleteHistoryManager> autocomplete_history_manager;
+  autocomplete_history_manager.reset(
+      new MockAutocompleteHistoryManager(autofill_driver_.get(), &delegate));
+  autofill_manager_->autocomplete_history_manager_.reset(
+      autocomplete_history_manager.get());

[Ilya Sherman, 2013/06/19 23:19:55]

Pretty sure this needs to be .Pass(), or else you'll have a double-free.

[sgurun-gerrit only, 2013/06/20 15:18:44]

You are right. thanks.

On 2013/06/19 23:19:55, Ilya Sherman wrote:

+
+  // Set up our form data.
+  FormData form;
+  CreateTestAddressFormData(&form);
+  form.method = ASCIIToUTF16("GET");
+  FormSubmitted(form);
+  EXPECT_CALL(*(autocomplete_history_manager.get()),
+              OnFormSubmitted(_)).Times(1);

[Ilya Sherman, 2013/06/19 23:19:55]

I'm pretty sure this is supposed to go *before* the code that's expected to
trigger it.

[sgurun-gerrit only, 2013/06/20 15:18:44]

Done.

+}
+
+// Test that when Autocomplete is enabled and Autofill is disabled,
+// Autocomplete suggestions are still received.
+TEST_F(AutofillManagerTest, AutocompleteSuggestionsWhenAutofillDisabled) {
+  TestAutofillManagerDelegate delegate;
+  autofill_manager_.reset(new TestAutofillManager(
+      autofill_driver_.get(),
+      &delegate,
+      NULL));
+  autofill_manager_->set_autofill_enabled(false);
+
+  // Set up our form data.
+  FormData form;
+  CreateTestAddressFormData(&form);
+  form.method = ASCIIToUTF16("GET");
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+  const FormFieldData& field = form.fields[0];
+  GetAutofillSuggestions(form, field);
+
+  // Add some Autocomplete suggestions. We should return the autocomplete
+  // suggestions, these will be culled by the renderer.
+  std::vector<base::string16> suggestions;
+  suggestions.push_back(ASCIIToUTF16("Jay"));
+  suggestions.push_back(ASCIIToUTF16("Jason"));
+  AutocompleteSuggestionsReturned(suggestions);
+
+  int page_id = 0;
+  std::vector<base::string16> values;
+  std::vector<base::string16> labels;
+  std::vector<base::string16> icons;
+  std::vector<int> unique_ids;
+  EXPECT_TRUE(GetAutofillSuggestionsMessage(&page_id, &values, &labels, &icons,
+                                            &unique_ids));
+
+  base::string16 expected_values[] = {
+    ASCIIToUTF16("Jay"),
+    ASCIIToUTF16("Jason")
+  };
+  base::string16 expected_labels[] = { base::string16(), base::string16()};
+  base::string16 expected_icons[] = { base::string16(), base::string16()};
+  int expected_unique_ids[] = {0, 0};
+  ExpectSuggestions(page_id, values, labels, icons, unique_ids,
+                    kDefaultPageID, arraysize(expected_values), expected_values,
+                    expected_labels, expected_icons, expected_unique_ids);
+}
+
 // Test that we are able to save form data when forms are submitted and we only
 // have server data for the field types.
 TEST_F(AutofillManagerTest, FormSubmittedServerTypes) {
   // Set up our form data.
   FormData form;
   CreateTestAddressFormData(&form);
 
   // Simulate having seen this form on page load.
   // |form_structure| will be owned by |autofill_manager_|.
   TestFormStructure* form_structure = new TestFormStructure(form);
@@ skipping 562 matching lines @@
   CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   autofill_manager_->SetExternalDelegate(NULL);
 }
 
 }  // namespace autofill