Enable Autocomplete feature for chromium webview

components/autofill/browser/autofill_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 173 matching lines @@
 
 AutofillManager::AutofillManager(
     AutofillDriver* driver,
     autofill::AutofillManagerDelegate* delegate,
     const std::string& app_locale,
     AutofillDownloadManagerState enable_download_manager)
     : driver_(driver),
       manager_delegate_(delegate),
       app_locale_(app_locale),
       personal_data_(delegate->GetPersonalDataManager()),
-      autocomplete_history_manager_(driver),
       autocheckout_manager_(this),
       metric_logger_(new AutofillMetrics),
       has_logged_autofill_enabled_(false),
       has_logged_address_suggestions_count_(false),
       did_show_suggestions_(false),
       user_did_type_(false),
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       external_delegate_(NULL),
       test_delegate_(NULL),
       weak_ptr_factory_(this) {
+  autocomplete_history_manager_.reset(
+      new AutocompleteHistoryManager(driver,delegate));

[Ilya Sherman, 2013/06/19 00:38:27]

nit: Please include a space after the comma.

[Ilya Sherman, 2013/06/19 00:38:27]

nit: Why did this get moved out of the initializer list?

[sgurun-gerrit only, 2013/06/19 17:56:23]

Done.

[sgurun-gerrit only, 2013/06/19 17:56:23]

Done.

   if (enable_download_manager == ENABLE_AUTOFILL_DOWNLOAD_MANAGER) {
     download_manager_.reset(
         new AutofillDownloadManager(
             driver->GetWebContents()->GetBrowserContext(), this));
   }
 }
 
 AutofillManager::~AutofillManager() {}
 
 // static
@@ skipping 29 matching lines @@
     const content::FrameNavigateParams& params) {
   if (details.is_navigation_to_different_page())
     Reset();
 }
 
 void AutofillManager::SetExternalDelegate(AutofillExternalDelegate* delegate) {
   // TODO(jrg): consider passing delegate into the ctor.  That won't
   // work if the delegate has a pointer to the AutofillManager, but
   // future directions may not need such a pointer.
   external_delegate_ = delegate;
-  autocomplete_history_manager_.SetExternalDelegate(delegate);
+  autocomplete_history_manager_->SetExternalDelegate(delegate);
 }
 
 bool AutofillManager::IsNativeUiEnabled() {
   return external_delegate_ != NULL;
 }
 
 bool AutofillManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AutofillManager, message)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_FormsSeen, OnFormsSeen)
@@ skipping 31 matching lines @@
     IPC_MESSAGE_HANDLER(AutofillHostMsg_RemoveAutocompleteEntry,
                         RemoveAutocompleteEntry)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
   return handled;
 }
 
 bool AutofillManager::OnFormSubmitted(const FormData& form,
                                       const TimeTicks& timestamp) {
-  // Let AutoComplete know as well.
-  autocomplete_history_manager_.OnFormSubmitted(form);
+  // Let Autocomplete know as well.
+  autocomplete_history_manager_->OnFormSubmitted(form);
 
   if (!IsAutofillEnabled())
     return false;
 
   if (driver_->GetWebContents()->GetBrowserContext()->IsOffTheRecord())
     return false;
 
   // Don't save data that was submitted through JavaScript.
   if (!form.user_submitted)
     return false;
@@ skipping 213 matching lines @@
           metric_logger_->LogAddressSuggestionsCount(values.size());
           has_logged_address_suggestions_count_ = true;
         }
       }
     }
   }
 
   // Add the results from AutoComplete.  They come back asynchronously, so we
   // hand off what we generated and they will send the results back to the
   // renderer.
-  autocomplete_history_manager_.OnGetAutocompleteSuggestions(
+  autocomplete_history_manager_->OnGetAutocompleteSuggestions(
       query_id, field.name, field.value, values, labels, icons, unique_ids);
 }
 
 void AutofillManager::OnFillAutofillFormData(int query_id,
                                              const FormData& form,
                                              const FormFieldData& field,
                                              int unique_id) {
   RenderViewHost* host = NULL;
   const AutofillDataModel* data_model = NULL;
   size_t variant = 0;
@@ skipping 133 matching lines @@
   // be deleted, instead of doing nothing.
   // http://crbug.com/124211
   if (variant != 0)
     return;
 
   personal_data_->RemoveByGUID(data_model->guid());
 }
 
 void AutofillManager::RemoveAutocompleteEntry(const base::string16& name,
                                               const base::string16& value) {
-  autocomplete_history_manager_.OnRemoveAutocompleteEntry(name, value);
+  autocomplete_history_manager_->OnRemoveAutocompleteEntry(name, value);
 }
 
 content::WebContents* AutofillManager::GetWebContents() const {
   return driver_->GetWebContents();
 }
 
 const std::vector<FormStructure*>& AutofillManager::GetFormStructures() {
   return form_structures_.get();
 }
 
@@ skipping 251 matching lines @@
     external_delegate_->Reset();
 }
 
 AutofillManager::AutofillManager(AutofillDriver* driver,
                                  autofill::AutofillManagerDelegate* delegate,
                                  PersonalDataManager* personal_data)
     : driver_(driver),
       manager_delegate_(delegate),
       app_locale_("en-US"),
       personal_data_(personal_data),
-      autocomplete_history_manager_(driver),
       autocheckout_manager_(this),
       metric_logger_(new AutofillMetrics),
       has_logged_autofill_enabled_(false),
       has_logged_address_suggestions_count_(false),
       did_show_suggestions_(false),
       user_did_type_(false),
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       external_delegate_(NULL),
       test_delegate_(NULL),
       weak_ptr_factory_(this) {
+  autocomplete_history_manager_.reset(
+      new AutocompleteHistoryManager(driver, delegate));

[Ilya Sherman, 2013/06/19 00:38:27]

nit: Why did this get moved out of the initializer list?

[sgurun-gerrit only, 2013/06/19 17:56:23]

Done.

   DCHECK(driver_);
   DCHECK(driver_->GetWebContents());
   DCHECK(manager_delegate_);
 }
 
 void AutofillManager::set_metric_logger(const AutofillMetrics* metric_logger) {
   metric_logger_.reset(metric_logger);
 }
 
 bool AutofillManager::GetHost(RenderViewHost** host) const {
@@ skipping 303 matching lines @@
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }
 
 }  // namespace autofill