Enable Autocomplete feature for chromium webview

components/autofill/browser/autocomplete_history_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/autocomplete_history_manager.h"
 
 #include <vector>
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/browser/autofill_external_delegate.h"
+#include "components/autofill/browser/autofill_manager_delegate.h"
 #include "components/autofill/browser/validation.h"
 #include "components/autofill/common/autofill_messages.h"
 #include "components/autofill/common/autofill_pref_names.h"
 #include "components/autofill/common/form_data.h"
-#include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 
 using content::BrowserContext;
 using content::WebContents;
 
 namespace autofill {
 namespace {
 
 // Limit on the number of suggestions to appear in the pop-up menu under an
 // text input element in a form.
 const int kMaxAutocompleteMenuItems = 6;
 
 bool IsTextField(const FormFieldData& field) {
   return
       field.form_control_type == "text" ||
       field.form_control_type == "search" ||
       field.form_control_type == "tel" ||
       field.form_control_type == "url" ||
       field.form_control_type == "email" ||
       field.form_control_type == "text";
 }
 
 }  // namespace
 
 AutocompleteHistoryManager::AutocompleteHistoryManager(
-    WebContents* web_contents)
+    WebContents* web_contents,
+    autofill::AutofillManagerDelegate* const manager_delegate)
     : content::WebContentsObserver(web_contents),
       browser_context_(web_contents->GetBrowserContext()),
       autofill_data_(
           AutofillWebDataService::FromBrowserContext(browser_context_)),
       pending_query_handle_(0),
       query_id_(0),
-      external_delegate_(NULL) {
-  autofill_enabled_.Init(
-      prefs::kAutofillEnabled,
-      user_prefs::UserPrefs::Get(browser_context_));
+      external_delegate_(NULL),
+      manager_delegate_(manager_delegate) {
+  DCHECK(manager_delegate_);
 }
 
 AutocompleteHistoryManager::~AutocompleteHistoryManager() {
   CancelPendingQuery();
 }
 
 bool AutocompleteHistoryManager::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AutocompleteHistoryManager, message)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_RemoveAutocompleteEntry,
                         OnRemoveAutocompleteEntry)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutocompleteHistoryManager::OnWebDataServiceRequestDone(
     WebDataServiceBase::Handle h,
     const WDTypedResult* result) {
   DCHECK(pending_query_handle_);
   pending_query_handle_ = 0;
 
-  if (!*autofill_enabled_) {
+  if (!manager_delegate_->IsAutoCompleteEnabled()) {
     SendSuggestions(NULL);
     return;
   }
 
   DCHECK(result);
   // Returning early here if |result| is NULL.  We've seen this happen on
   // Linux due to NFS dismounting and causing sql failures.
   // See http://crbug.com/68783.
   if (!result) {
     SendSuggestions(NULL);
@@ skipping 15 matching lines @@
     const std::vector<base::string16>& autofill_labels,
     const std::vector<string16>& autofill_icons,
     const std::vector<int>& autofill_unique_ids) {
   CancelPendingQuery();
 
   query_id_ = query_id;
   autofill_values_ = autofill_values;
   autofill_labels_ = autofill_labels;
   autofill_icons_ = autofill_icons;
   autofill_unique_ids_ = autofill_unique_ids;
-  if (!*autofill_enabled_) {
+  if (!manager_delegate_->IsAutoCompleteEnabled()) {
     SendSuggestions(NULL);
     return;
   }
 
   if (autofill_data_.get()) {
     pending_query_handle_ = autofill_data_->GetFormValuesForElementName(
         name, prefix, kMaxAutocompleteMenuItems, this);
   }
 }
 
 void AutocompleteHistoryManager::OnFormSubmitted(const FormData& form) {
-  if (!*autofill_enabled_)
-    return;

[Ilya Sherman, 2013/06/18 05:56:25]

Why did you remove this check?

[sgurun-gerrit only, 2013/06/19 00:16:17]

weird. I have 
 if (!manager_delegate_->IsAutocompleteEnabled())
    return;
in my local file. I guess I forgot uploading it.
good catch.

On 2013/06/18 05:56:25, Ilya Sherman wrote:

-
   if (browser_context_->IsOffTheRecord())
     return;
 
   // Don't save data that was submitted through JavaScript.
   if (!form.user_submitted)
     return;
 
   // We put the following restriction on stored FormFields:
   //  - non-empty name
   //  - non-empty value
@@ skipping 76 matching lines @@
   }
 
   query_id_ = 0;
   autofill_values_.clear();
   autofill_labels_.clear();
   autofill_icons_.clear();
   autofill_unique_ids_.clear();
 }
 
 }  // namespace autofill