Issue 1509693002: Issue 25108. Add ExecutableElement(s) into the 'invalid override' messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1509693002: Issue 25108. Add ExecutableElement(s) into the 'invalid override' messages. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 25108. Add ExecutableElement(s) into the 'invalid override' messages. It uses the fact that ExecutableElement.toString() produces the full signature, with types and parameter names. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25108 Committed: https://github.com/dart-lang/sdk/commit/dad4baa7827e2557ba4eb7df2a83d369b3f8bdf4

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	pkg/analyzer/lib/src/generated/error.dart	View		3 chunks	+9 lines, -6 lines	0 comments	Download
	M	pkg/analyzer/lib/src/generated/error_verifier.dart	View		3 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

5 years ago (2015-12-07 21:59:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dad4baa7827e2557ba4eb7df2a83d369b3f8bdf4 (presubmit successful).