Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: media/blink/resource_multibuffer_data_provider.cc

Issue 1509663003: make multibuffer work with layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_cache.integrate3
Patch Set: merged & formatted Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer_reader.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/resource_multibuffer_data_provider.cc
diff --git a/media/blink/resource_multibuffer_data_provider.cc b/media/blink/resource_multibuffer_data_provider.cc
index 78bd2a0c22e48a26324acbca1022310514b50664..fb4a5dbef62c5275d78f72314f8929039190e23d 100644
--- a/media/blink/resource_multibuffer_data_provider.cc
+++ b/media/blink/resource_multibuffer_data_provider.cc
@@ -32,6 +32,10 @@ namespace media {
// The number of milliseconds to wait before retrying a failed load.
const int kLoaderFailedRetryDelayMs = 250;
+// The number of milliseconds to wait before retrying when the server
+// decides to not give us all the data at once.
+const int kLoaderPartialRetryDelayMs = 25;
+
const int kHttpOK = 200;
const int kHttpPartialContent = 206;
const int kHttpRangeNotSatisfiable = 416;
@@ -51,13 +55,16 @@ ResourceMultiBufferDataProvider::ResourceMultiBufferDataProvider(
}
void ResourceMultiBufferDataProvider::Start() {
- // In the case of a re-start, throw away any half-finished blocks.
- fifo_.clear();
// Prepare the request.
WebURLRequest request(url_data_->url());
// TODO(mkwst): Split this into video/audio.
request.setRequestContext(WebURLRequest::RequestContextVideo);
+ DVLOG(1) << __FUNCTION__ << " @ " << byte_pos();
+ if (url_data_->length() > 0) {
+ DCHECK_LT(byte_pos(), url_data_->length()) << " " << url_data_->url();
+ }
+
request.setHTTPHeaderField(
WebString::fromUTF8(net::HttpRequestHeaders::kRange),
WebString::fromUTF8(
@@ -142,7 +149,13 @@ void ResourceMultiBufferDataProvider::willFollowRedirect(
// This test is vital for security!
if (cors_mode_ == UrlData::CORS_UNSPECIFIED) {
+ // We allow the redirect if the origin is the same.
if (origin_ != redirects_to_.GetOrigin()) {
+ // We also allow the redirect if we don't have any data in the
+ // cache, as that means that no dangerous data mixing can occur.
+ if (url_data_->multibuffer()->map().empty() && fifo_.empty())
+ return;
+
url_data_->Fail();
}
}
@@ -358,12 +371,12 @@ void ResourceMultiBufferDataProvider::didFinishLoading(
if (url_data_->length() != kPositionNotSpecified &&
size < url_data_->length()) {
if (retries_ < kMaxRetries) {
- fifo_.clear();
+ DVLOG(1) << " Partial data received.... @ pos = " << size;
retries_++;
base::MessageLoop::current()->PostDelayedTask(
FROM_HERE, base::Bind(&ResourceMultiBufferDataProvider::Start,
weak_factory_.GetWeakPtr()),
- base::TimeDelta::FromMilliseconds(kLoaderFailedRetryDelayMs));
+ base::TimeDelta::FromMilliseconds(kLoaderPartialRetryDelayMs));
return;
} else {
scoped_ptr<ActiveLoader> active_loader = active_loader_.Pass();
@@ -390,7 +403,7 @@ void ResourceMultiBufferDataProvider::didFail(WebURLLoader* loader,
<< error.localizedDescription.utf8().data();
DCHECK(active_loader_.get());
- if (retries_ < kMaxRetries) {
+ if (retries_ < kMaxRetries && pos_ != 0) {
retries_++;
base::MessageLoop::current()->PostDelayedTask(
FROM_HERE, base::Bind(&ResourceMultiBufferDataProvider::Start,
@@ -449,7 +462,12 @@ bool ResourceMultiBufferDataProvider::ParseContentRange(
int64_t ResourceMultiBufferDataProvider::byte_pos() const {
int64_t ret = pos_;
- return ret << url_data_->multibuffer()->block_size_shift();
+ ret += fifo_.size();
+ ret = ret << url_data_->multibuffer()->block_size_shift();
+ if (!fifo_.empty()) {
+ ret += fifo_.back()->data_size() - block_size();
+ }
+ return ret;
}
int64_t ResourceMultiBufferDataProvider::block_size() const {
« no previous file with comments | « media/blink/multibuffer_reader.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698