Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 1509663003: make multibuffer work with layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_cache.integrate3
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/multibuffer_data_source_unittest.cc
diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc
index 3890af9448c812c835655aa9bf41c5c4a942db81..8d3717dbc1fb9c52f2b0074ca188be66f330ef19 100644
--- a/media/blink/multibuffer_data_source_unittest.cc
+++ b/media/blink/multibuffer_data_source_unittest.cc
@@ -243,8 +243,8 @@ class MultibufferDataSourceTest : public testing::Test {
&MultibufferDataSourceTest::OnInitialize, base::Unretained(this)));
message_loop_.RunUntilIdle();
- // Always loading after initialize.
- EXPECT_EQ(data_source_->downloading(), true);
+ // Not really loading until after OnInitialize is called.
+ EXPECT_EQ(data_source_->downloading(), false);
}
// Helper to initialize tests with a valid 200 response.
@@ -1035,10 +1035,10 @@ TEST_F(MultibufferDataSourceTest, File_FinishLoading) {
ReceiveData(kDataSize);
- EXPECT_TRUE(data_source_->downloading());
+ EXPECT_FALSE(data_source_->downloading());
// premature didFinishLoading() will cause a retry.
FinishLoading();
- EXPECT_TRUE(data_source_->downloading());
+ EXPECT_FALSE(data_source_->downloading());
Stop();
}

Powered by Google App Engine
This is Rietveld 408576698