[Android WebView] Remove testNavigateBackToNoncacheableLoginPage

[Android WebView] Remove testNavigateBackToNoncacheableLoginPage

The test had been "temporarily" disabled for >2 years. The login page
which it simulates had also been changed and doesn't exhibit
the original issue. There isn't seem to be a point in keeping the test.

BUG=567262
Committed: https://crrev.com/fa1ee70280d221edda6efdee535e3f4164663f9b
Cr-Commit-Position: refs/heads/master@{#363674}

[mnaganov (inactive), 2015-12-07 20:14:52]

mnaganov@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2015-12-07 21:55:37]

some nits, lgtm

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
(left):

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:227:
+ "    <title>" + LOGIN_PAGE_TITLE + "</title>"
this constant does not seem to be used anywhere else.

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:236:
+ "    <form action='" + LOGIN_RESPONSE_PAGE_PATH.substring(1) + "'
method='post'>"
same as above. can you check all the constants?

[mnaganov (inactive), 2015-12-07 23:54:43]

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
File
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
(left):

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:227:
+ "    <title>" + LOGIN_PAGE_TITLE + "</title>"
On 2015/12/07 21:55:36, sgurun wrote:
> this constant does not seem to be used anywhere else.

Yeah, I'm wondering why something like ProGuard didn't yell at me for not
removing them. Done.

https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:236:
+ "    <form action='" + LOGIN_RESPONSE_PAGE_PATH.substring(1) + "'
method='post'>"
On 2015/12/07 21:55:36, sgurun wrote:
> same as above. can you check all the constants?

Done.

[mnaganov (inactive), 2015-12-07 23:54:58]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2015-12-07 23:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/1509623002/#ps20001
(title: "Removed unused vars")

[sgurun-gerrit only, 2015-12-07 23:57:07]

On 2015/12/07 23:54:43, mnaganov wrote:
>
https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
> File
>
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java
> (left):
> 
>
https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
>
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:227:
> + "    <title>" + LOGIN_PAGE_TITLE + "</title>"
> On 2015/12/07 21:55:36, sgurun wrote:
> > this constant does not seem to be used anywhere else.
> 
> Yeah, I'm wondering why something like ProGuard didn't yell at me for not
> removing them. Done.
> 
>
https://codereview.chromium.org/1509623002/diff/1/android_webview/javatests/s...
>
android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java:236:
> + "    <form action='" + LOGIN_RESPONSE_PAGE_PATH.substring(1) + "'
> method='post'>"
> On 2015/12/07 21:55:36, sgurun wrote:
> > same as above. can you check all the constants?
> 
> Done.

lgtm, thanks

[commit-bot: I haz the power, 2015-12-07 23:59:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509623002/20001

[commit-bot: I haz the power, 2015-12-08 01:18:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-08 01:19:14]

Description was changed from

==========
[Android WebView] Remove testNavigateBackToNoncacheableLoginPage

The test had been "temporarily" disabled for >2 years. The login page
which it simulates had also been changed and doesn't exhibit
the original issue. There isn't seem to be a point in keeping the test.

BUG=567262
==========

to

==========
[Android WebView] Remove testNavigateBackToNoncacheableLoginPage

The test had been "temporarily" disabled for >2 years. The login page
which it simulates had also been changed and doesn't exhibit
the original issue. There isn't seem to be a point in keeping the test.

BUG=567262

Committed: https://crrev.com/fa1ee70280d221edda6efdee535e3f4164663f9b
Cr-Commit-Position: refs/heads/master@{#363674}
==========

[commit-bot: I haz the power, 2015-12-08 01:19:15]

Patchset 2 (id:??) landed as
https://crrev.com/fa1ee70280d221edda6efdee535e3f4164663f9b
Cr-Commit-Position: refs/heads/master@{#363674}