[runtime] [proxy] implement [[Construct]]

[runtime] [proxy] implement [[Construct]]

LOG=N
BUG=v8:1543
Committed: https://crrev.com/a2d5641bc42f561117ed77c28fe672d33581a4ca
Cr-Commit-Position: refs/heads/master@{#32718}

[Camillo Bruni, 2015-12-08 10:40:31]

cbruni@chromium.org changed reviewers:
+ mlippautz@chromium.org, verwaest@chromium.org

[Camillo Bruni, 2015-12-08 10:40:32]

PTAL

mlippautz: please check heap.h

[Camillo Bruni, 2015-12-08 15:35:06]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 15:35:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/40001

[commit-bot: I haz the power, 2015-12-08 15:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 15:39:12]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11768)

[Camillo Bruni, 2015-12-08 15:44:25]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 15:44:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/60001

[commit-bot: I haz the power, 2015-12-08 15:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 15:48:05]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12876)

[Camillo Bruni, 2015-12-08 16:16:00]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 16:16:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/80001

[commit-bot: I haz the power, 2015-12-08 16:19:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 16:19:17]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12879)

[Camillo Bruni, 2015-12-08 16:19:36]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 16:19:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/100001

[commit-bot: I haz the power, 2015-12-08 17:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 17:46:50]

Dry run: Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/11454)

[Toon Verwaest, 2015-12-08 20:27:22]

Looking good; some minor nits. Additionally, please fix and reenable
test/mjsunit/es6/classes-proxy.js
(https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/mjsunit/mj...)

https://codereview.chromium.org/1509603005/diff/100001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1509603005/diff/100001/src/arm/builtins-arm.c...
src/arm/builtins-arm.cc:1755: // Include the pushed new_target + constructor and
the receiver on the stack.
just use ,: new_target, constructor, and the receiver.

https://codereview.chromium.org/1509603005/diff/100001/src/runtime/runtime-pr...
File src/runtime/runtime-proxy.cc (right):

https://codereview.chromium.org/1509603005/diff/100001/src/runtime/runtime-pr...
src/runtime/runtime-proxy.cc:117: Handle<JSArray> arg_array =
isolate->factory()->NewJSArray(
Could you add a test that this array is created in the right realm for 2 cases:

(new proxy) should get an array from the outer realm. (Add a test that
constructs a proxy from a second realm from the first realm.)

Reflect.construct(proxy) should get an array from the realm of the construct
method on Reflect. (So create 3 realms and all from the first to
Reflect.construct from the second with a proxy target from the third. The array
has to be from the second.)

Callable proxies inherit the realm from their target.

https://codereview.chromium.org/1509603005/diff/100001/test/mjsunit/harmony/p...
File test/mjsunit/harmony/proxies-construct.js (right):

https://codereview.chromium.org/1509603005/diff/100001/test/mjsunit/harmony/p...
test/mjsunit/harmony/proxies-construct.js:74: var seend_target, seen_arguments,
seen_new_target;
seend? :)

[Camillo Bruni, 2015-12-09 12:14:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 12:14:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/140001

[Camillo Bruni, 2015-12-09 12:15:44]

PTAL
- added cross realm tests for Reflect.construct and Proxy.[[Construct]]
- fixed and enabled classes-proxy.js tests
- updated comments on all builtins-XY.cc

https://codereview.chromium.org/1509603005/diff/100001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1509603005/diff/100001/src/arm/builtins-arm.c...
src/arm/builtins-arm.cc:1755: // Include the pushed new_target + constructor and
the receiver on the stack.
On 2015/12/08 at 20:27:22, Toon Verwaest wrote:
> just use ,: new_target, constructor, and the receiver.

good, just fixed this particular comment :D

https://codereview.chromium.org/1509603005/diff/100001/test/mjsunit/harmony/p...
File test/mjsunit/harmony/proxies-construct.js (right):

https://codereview.chromium.org/1509603005/diff/100001/test/mjsunit/harmony/p...
test/mjsunit/harmony/proxies-construct.js:74: var seend_target, seen_arguments,
seen_new_target;
On 2015/12/08 at 20:27:22, Toon Verwaest wrote:
> seend? :)

see, seen, seend, isn't that obivous?

[commit-bot: I haz the power, 2015-12-09 13:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 13:15:38]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2015-12-09 14:38:42]

lgtm

[Camillo Bruni, 2015-12-09 14:53:42]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-09 14:53:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/140001

[commit-bot: I haz the power, 2015-12-09 14:55:04]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-09 14:55:41]

Description was changed from

==========
[runtime] [proxy] implement [[Construct]]

LOG=N
BUG=v8:1543
==========

to

==========
[runtime] [proxy] implement [[Construct]]

LOG=N
BUG=v8:1543

Committed: https://crrev.com/a2d5641bc42f561117ed77c28fe672d33581a4ca
Cr-Commit-Position: refs/heads/master@{#32718}
==========

[commit-bot: I haz the power, 2015-12-09 14:55:42]

Patchset 8 (id:??) landed as
https://crrev.com/a2d5641bc42f561117ed77c28fe672d33581a4ca
Cr-Commit-Position: refs/heads/master@{#32718}

[Camillo Bruni, 2015-12-09 15:53:11]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 15:53:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509603005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509603005/160001

[commit-bot: I haz the power, 2015-12-09 15:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 15:54:00]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12934)