Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: test/cctest/test-mark-compact.cc

Issue 15096011: Various minor cctest fixes to make ASAN a bit happier. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-mark-compact.cc
diff --git a/test/cctest/test-mark-compact.cc b/test/cctest/test-mark-compact.cc
index 2cb4646d5a8209a06d5116b61b5e10d18f35ce31..33fb8c3bfd58568de25f61957ff31d6ce0650250 100644
--- a/test/cctest/test-mark-compact.cc
+++ b/test/cctest/test-mark-compact.cc
@@ -469,8 +469,9 @@ TEST(EmptyObjectGroups) {
// Here is a memory use test that uses /proc, and is therefore Linux-only. We
// do not care how much memory the simulator uses, since it is only there for
-// debugging purposes.
-#if defined(__linux__) && !defined(USE_SIMULATOR)
+// debugging purposes. Testing with ASAN doesn't make sense, either.
+#if defined(__linux__) && !defined(USE_SIMULATOR) && \
+ !(defined(__has_feature) && __has_feature(address_sanitizer))
Sven Panne 2013/05/15 08:59:02 I had to do this check slightly different, otherwi
static uintptr_t ReadLong(char* buffer, intptr_t* position, int base) {

Powered by Google App Engine
This is Rietveld 408576698