Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 15096011: Various minor cctest fixes to make ASAN a bit happier. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Various minor cctest fixes to make ASAN a bit happier. * Running with ASAN needs more stack, so don't set resource constraints too tight. * Checking boot time memory usage doesn't make sense when running with ASAN, it eats tons of memory for itself. * Fixed a malloc/delete[] mismatch: Not surprisingly, the pointer wrapped by a SmartArrayPointer should better be allocated by, well, NewArray... Even with these 3 fixes, we still have a few failures when running our test suite with ASAN. Most of them are either timeouts or failures caused by greatly increased stack usage. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14674

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased. Feedback. Fixed ASAN check for GCC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
test/cctest/test-api.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
test/cctest/test-mark-compact.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download
test/cctest/test-parsing.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years, 7 months ago (2013-05-15 08:05:50 UTC) #1
Michael Starzinger
LGTM with a nit. https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc#newcode15887 test/cctest/test-api.cc:15887: static const int stack_breathing_room = ...
7 years, 7 months ago (2013-05-15 08:23:48 UTC) #2
Sven Panne
Landing https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/15096011/diff/1/test/cctest/test-api.cc#newcode15887 test/cctest/test-api.cc:15887: static const int stack_breathing_room = 256 * 1024; ...
7 years, 7 months ago (2013-05-15 08:59:02 UTC) #3
Sven Panne
7 years, 7 months ago (2013-05-15 08:59:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698