Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java

Issue 15096008: Report NON_CONSTANT_VALUE_IN_INITIALIZER (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix for names Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java ('k') | tests/co19/co19-analyzer.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
index a4670c6f35f062163e625e1817a3ef49a494220a..37c8a044cf89596b9b8412645bf2a26ce2f42a72 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java
@@ -260,6 +260,66 @@ public class NonErrorResolverTest extends ResolverTestCase {
verify(source);
}
+ public void test_constEvalTypeBoolNumString_equal() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " const A();",
+ "}",
+ "class B {",
+ " final v;",
+ " const B.a1(bool p) : v = p == true;",
+ " const B.a2(bool p) : v = p == false;",
+ " const B.a3(bool p) : v = p == 0;",
+ " const B.a4(bool p) : v = p == 0.0;",
+ " const B.a5(bool p) : v = p == '';",
+ " const B.b1(int p) : v = p == true;",
+ " const B.b2(int p) : v = p == false;",
+ " const B.b3(int p) : v = p == 0;",
+ " const B.b4(int p) : v = p == 0.0;",
+ " const B.b5(int p) : v = p == '';",
+ " const B.c1(String p) : v = p == true;",
+ " const B.c2(String p) : v = p == false;",
+ " const B.c3(String p) : v = p == 0;",
+ " const B.c4(String p) : v = p == 0.0;",
+ " const B.c5(String p) : v = p == '';",
+ " const B.n1(num p) : v = p == null;",
+ " const B.n2(num p) : v = null == p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_constEvalTypeBoolNumString_notEqual() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " const A();",
+ "}",
+ "class B {",
+ " final v;",
+ " const B.a1(bool p) : v = p != true;",
+ " const B.a2(bool p) : v = p != false;",
+ " const B.a3(bool p) : v = p != 0;",
+ " const B.a4(bool p) : v = p != 0.0;",
+ " const B.a5(bool p) : v = p != '';",
+ " const B.b1(int p) : v = p != true;",
+ " const B.b2(int p) : v = p != false;",
+ " const B.b3(int p) : v = p != 0;",
+ " const B.b4(int p) : v = p != 0.0;",
+ " const B.b5(int p) : v = p != '';",
+ " const B.c1(String p) : v = p != true;",
+ " const B.c2(String p) : v = p != false;",
+ " const B.c3(String p) : v = p != 0;",
+ " const B.c4(String p) : v = p != 0.0;",
+ " const B.c5(String p) : v = p != '';",
+ " const B.n1(num p) : v = p != null;",
+ " const B.n2(num p) : v = null != p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
public void test_constWithNonConstantArgument_literals() throws Exception {
Source source = addSource(createSource(//
"class A {",
@@ -926,6 +986,150 @@ public class NonErrorResolverTest extends ResolverTestCase {
verify(source);
}
+ public void test_nonConstValueInInitializer_binary_bool() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final v;",
+ " const A.a1(bool p) : v = p && true;",
+ " const A.a2(bool p) : v = true && p;",
+ " const A.b1(bool p) : v = p || true;",
+ " const A.b2(bool p) : v = true || p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_binary_dynamic() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final v;",
+ " const A.a1(p) : v = p + 5;",
+ " const A.a2(p) : v = 5 + p;",
+ " const A.b1(p) : v = p - 5;",
+ " const A.b2(p) : v = 5 - p;",
+ " const A.c1(p) : v = p * 5;",
+ " const A.c2(p) : v = 5 * p;",
+ " const A.d1(p) : v = p / 5;",
+ " const A.d2(p) : v = 5 / p;",
+ " const A.e1(p) : v = p ~/ 5;",
+ " const A.e2(p) : v = 5 ~/ p;",
+ " const A.f1(p) : v = p > 5;",
+ " const A.f2(p) : v = 5 > p;",
+ " const A.g1(p) : v = p < 5;",
+ " const A.g2(p) : v = 5 < p;",
+ " const A.h1(p) : v = p >= 5;",
+ " const A.h2(p) : v = 5 >= p;",
+ " const A.i1(p) : v = p <= 5;",
+ " const A.i2(p) : v = 5 <= p;",
+ " const A.j1(p) : v = p % 5;",
+ " const A.j2(p) : v = 5 % p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ // operations on "p" are not resolved
+ }
+
+ public void test_nonConstValueInInitializer_binary_int() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final v;",
+ " const A.a1(int p) : v = p ^ 5;",
+ " const A.a2(int p) : v = 5 ^ p;",
+ " const A.b1(int p) : v = p & 5;",
+ " const A.b2(int p) : v = 5 & p;",
+ " const A.c1(int p) : v = p | 5;",
+ " const A.c2(int p) : v = 5 | p;",
+ " const A.d1(int p) : v = p >> 5;",
+ " const A.d2(int p) : v = 5 >> p;",
+ " const A.e1(int p) : v = p << 5;",
+ " const A.e2(int p) : v = 5 << p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_binary_num() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final v;",
+ " const A.a1(num p) : v = p + 5;",
+ " const A.a2(num p) : v = 5 + p;",
+ " const A.b1(num p) : v = p - 5;",
+ " const A.b2(num p) : v = 5 - p;",
+ " const A.c1(num p) : v = p * 5;",
+ " const A.c2(num p) : v = 5 * p;",
+ " const A.d1(num p) : v = p / 5;",
+ " const A.d2(num p) : v = 5 / p;",
+ " const A.e1(num p) : v = p ~/ 5;",
+ " const A.e2(num p) : v = 5 ~/ p;",
+ " const A.f1(num p) : v = p > 5;",
+ " const A.f2(num p) : v = 5 > p;",
+ " const A.g1(num p) : v = p < 5;",
+ " const A.g2(num p) : v = 5 < p;",
+ " const A.h1(num p) : v = p >= 5;",
+ " const A.h2(num p) : v = 5 >= p;",
+ " const A.i1(num p) : v = p <= 5;",
+ " const A.i2(num p) : v = 5 <= p;",
+ " const A.j1(num p) : v = p % 5;",
+ " const A.j2(num p) : v = 5 % p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_field() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final int a;",
+ " const A() : a = 5;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_redirecting() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " static C;",
+ " const A.named(p);",
+ " const A() : this.named(42);",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_super() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " const A(p);",
+ "}",
+ "class B {",
+ " static C;",
+ " const B() : super(42);",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
+ public void test_nonConstValueInInitializer_unary() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " final v;",
+ " const A.a(bool p) : v = !p;",
+ " const A.b(int p) : v = ~p;",
+ " const A.c(num p) : v = -p;",
+ "}"));
+ resolve(source);
+ assertNoErrors();
+ verify(source);
+ }
+
public void test_nonTypeInCatchClause_isClass() throws Exception {
Source source = addSource(createSource(//
"f() {",
« no previous file with comments | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java ('k') | tests/co19/co19-analyzer.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698