Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart

Issue 15096006: Handle constants that mix eager and deferred types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/compiler/dart2js_extra/deferred/deferred_class_library.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart
diff --git a/dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart b/dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart
index f27bf45149aaa0b9715d3cdb2f08fa012ca40f8c..877289346d5e58728e22494a7f9b49b60ab22fe9 100644
--- a/dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart
+++ b/dart/tests/compiler/dart2js_extra/deferred/deferred_constant_test.dart
@@ -11,8 +11,9 @@ const lazy = const DeferredLibrary('deferred_class_library');
main() {
var x;
- // TODO(ahe): What are the semantics of this:
- // x = const MyClass();
+ Expect.isNull(const MyClass());
+ Expect.isNull(const Constant(42));
+ Expect.isNull(const [const Constant(42)]);
Expect.isNull(x);
int counter = 0;
lazy.load().then((bool didLoad) {
@@ -21,6 +22,7 @@ main() {
print('deferred_class_library was loaded');
x = const MyClass();
Expect.equals(42, x.foo(87));
+ Expect.listEquals(const [const Constant(42)], [new Constant(42)]);
});
Expect.equals(0, counter);
Expect.isNull(x);
@@ -30,10 +32,11 @@ main() {
print('deferred_class_library was loaded');
x = const MyClass();
Expect.equals(42, x.foo(87));
+ Expect.listEquals(const [const Constant(42)], [new Constant(42)]);
});
Expect.equals(0, counter);
Expect.isNull(x);
- // TODO(ahe): What are the semantics of this:
- // x = const MyClass();
+ Expect.isNull(const Constant(42));
+ Expect.isNull(const [const Constant(42)]);
Expect.isNull(x);
}
« no previous file with comments | « dart/tests/compiler/dart2js_extra/deferred/deferred_class_library.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698