Passing hit breakpoint IDs to ScriptDebugServer.

Source/devtools/front_end/BreakpointManager.js

Index: Source/devtools/front_end/BreakpointManager.js
diff --git a/Source/devtools/front_end/BreakpointManager.js b/Source/devtools/front_end/BreakpointManager.js
index 02910f7391a4bc67fe8400985127b0b120ea3d72..e0567e571562e846e57d7980c42f583e57166316 100644
--- a/Source/devtools/front_end/BreakpointManager.js
+++ b/Source/devtools/front_end/BreakpointManager.js
@@ -507,45 +507,45 @@ WebInspector.BreakpointManager.Breakpoint.prototype = {
         var rawLocation = this._primaryUILocation.uiLocationToRawLocation();
         var debuggerModelLocation = /** @type {WebInspector.DebuggerModel.Location} */ (rawLocation);
         if (debuggerModelLocation)
-            this._breakpointManager._debuggerModel.setBreakpointByScriptLocation(debuggerModelLocation, this._condition, didSetBreakpoint.bind(this));
+            this._breakpointManager._debuggerModel.setBreakpointByScriptLocation(debuggerModelLocation, this._condition, this._didSetBreakpointInDebugger.bind(this));
         else
-            this._breakpointManager._debuggerModel.setBreakpointByURL(this._primaryUILocation.uiSourceCode.url, this._primaryUILocation.lineNumber, 0, this._condition, didSetBreakpoint.bind(this));
-
-        /**
-         * @this {WebInspector.BreakpointManager.Breakpoint}
-         * @param {?DebuggerAgent.BreakpointId} breakpointId
-         * @param {Array.<WebInspector.DebuggerModel.Location>} locations
-         */
-        function didSetBreakpoint(breakpointId, locations)
-        {
-            if (!breakpointId) {
-                this._resetLocations();
-                this._breakpointManager._removeBreakpoint(this, false);
-                return;
-            }
+            this._breakpointManager._debuggerModel.setBreakpointByURL(this._primaryUILocation.uiSourceCode.url, this._primaryUILocation.lineNumber, 0, this._condition, this._didSetBreakpointInDebugger.bind(this));
+    },
 
-            this._debuggerId = breakpointId;
-            this._breakpointManager._breakpointForDebuggerId[breakpointId] = this;
+    /**
+    * @this {WebInspector.BreakpointManager.Breakpoint}
+    * @param {?DebuggerAgent.BreakpointId} breakpointId
+    * @param {Array.<WebInspector.DebuggerModel.Location>} locations
+    */
+    _didSetBreakpointInDebugger: function(breakpointId, locations)

[yurys, 2013/06/05 08:07:36]

Why did it become a method available to other functions?

[SeRya, 2013/06/05 11:34:57]

I sniff it in tests.

+    {
+        if (!breakpointId) {
+            this._resetLocations();
+            this._breakpointManager._removeBreakpoint(this, false);
+            return;
+        }
 
-            if (!locations.length) {
-                this._fakeBreakpointAtPrimaryLocation();
-                return;
-            }
+        this._debuggerId = breakpointId;
+        this._breakpointManager._breakpointForDebuggerId[breakpointId] = this;
 
-            this._resetLocations();
-            for (var i = 0; i < locations.length; ++i) {
-                var script = this._breakpointManager._debuggerModel.scriptForId(locations[i].scriptId);
-                var uiLocation = script.rawLocationToUILocation(locations[i].lineNumber, locations[i].columnNumber);
-                if (this._breakpointManager.findBreakpoint(uiLocation.uiSourceCode, uiLocation.lineNumber)) {
-                    // location clash
-                    this.remove();
-                    return;
-                }
-            }
+        if (!locations.length) {
+            this._fakeBreakpointAtPrimaryLocation();
+            return;
+        }
 
-            for (var i = 0; i < locations.length; ++i)
-                this._addResolvedLocation(locations[i]);
+        this._resetLocations();
+        for (var i = 0; i < locations.length; ++i) {
+            var script = this._breakpointManager._debuggerModel.scriptForId(locations[i].scriptId);
+            var uiLocation = script.rawLocationToUILocation(locations[i].lineNumber, locations[i].columnNumber);
+            if (this._breakpointManager.findBreakpoint(uiLocation.uiSourceCode, uiLocation.lineNumber)) {
+                // location clash
+                this.remove();

[yurys, 2013/06/05 08:07:36]

Is there a semantic change in this code? If not, please revert.

[SeRya, 2013/06/05 11:34:57]

As above: no semantic change but used in tests.

+                return;
+            }
         }
+
+        for (var i = 0; i < locations.length; ++i)
+            this._addResolvedLocation(locations[i]);
     },
 
     _removeFromDebugger: function()