Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: Source/bindings/v8/DebuggerScript.js

Issue 15096004: Passing hit breakpoint IDs to ScriptDebugServer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 if (eventData.script().data() === "injected-script") 264 if (eventData.script().data() === "injected-script")
265 return; 265 return;
266 eventData.script().setSource(source); 266 eventData.script().setSource(source);
267 } 267 }
268 268
269 DebuggerScript.getScriptName = function(eventData) 269 DebuggerScript.getScriptName = function(eventData)
270 { 270 {
271 return eventData.script().script_.nameOrSourceURL(); 271 return eventData.script().script_.nameOrSourceURL();
272 } 272 }
273 273
274 DebuggerScript.getBreakpointNumbers = function(eventData)
yurys 2013/05/16 19:52:53 getBreakpointsIds would be a better name
SeRya 2013/05/30 07:45:57 I think the name is right. V8 uses term "number".
275 {
276 var breakpoints = eventData.breakPointsHit();
277 var numbers = [];
yurys 2013/05/16 19:52:53 ids
SeRya 2013/05/30 07:45:57 The same.
278 if (breakpoints) {
279 for (var i = 0; i < breakpoints.length; i++) {
280 var b = breakpoints[i];
yurys 2013/05/16 19:52:53 b -> breakpoint we normally don't use abbreviation
281 var scriptBreakPoint = b.script_break_point();
282 numbers.push(scriptBreakPoint ? scriptBreakPoint.number() : b.number ());
283 }
284 }
285 return numbers;
286 }
287
274 DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame) 288 DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame)
275 { 289 {
276 // Get function name. 290 // Get function name.
277 var func; 291 var func;
278 try { 292 try {
279 func = frameMirror.func(); 293 func = frameMirror.func();
280 } catch(e) { 294 } catch(e) {
281 } 295 }
282 var functionName; 296 var functionName;
283 if (func) 297 if (func)
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 break; 373 break;
360 case ScopeType.Block: 374 case ScopeType.Block:
361 // Unsupported yet. Mustn't be reachable. 375 // Unsupported yet. Mustn't be reachable.
362 break; 376 break;
363 } 377 }
364 return scopeObject; 378 return scopeObject;
365 } 379 }
366 380
367 return DebuggerScript; 381 return DebuggerScript;
368 })(); 382 })();
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/ScriptDebugServer.h » ('j') | Source/bindings/v8/ScriptDebugServer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698