Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1509583003: Update the depot_tools version of VS 2015 to Update 1 (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the depot_tools version of VS 2015 to Update 1 This uses VS 2015 Update 1 and the 10.0.10586.0 SDK, created by an updated depot_tools\win_toolchain\package_from_installed.py R=scottmg@chromium.org BUG=440500, 567328 Committed: https://crrev.com/d6491e05a583e957148ba5d901cbfe50ce18d3d8 Cr-Commit-Position: refs/heads/master@{#363645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
PTAL. This is an initial pass at packaging Update 1. It builds on my machine.
5 years ago (2015-12-07 21:46:58 UTC) #1
scottmg
"Works on Your Machine"-lgtm
5 years ago (2015-12-07 22:06:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509583003/1
5 years ago (2015-12-07 22:12:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 00:53:06 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-08 00:54:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6491e05a583e957148ba5d901cbfe50ce18d3d8
Cr-Commit-Position: refs/heads/master@{#363645}

Powered by Google App Engine
This is Rietveld 408576698