Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1509523002: add completions in assert stmt - fixes #24888 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-07 17:31:07 UTC) #2
scheglov
LGTM
5 years ago (2015-12-07 17:36:48 UTC) #3
danrubel
5 years ago (2015-12-07 17:51:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
89168a1956726d9f725a825df9ec586740ea0e34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698