Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1509513002: Remove ScopedVector from proxy_resolver_factory_mojo_unittest (Closed)

Created:
5 years ago by Olli Raula
Modified:
5 years ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from proxy_resolver_factory_mojo_unittest Replace ScopedVector with std::vector<scoped_ptr> in proxy_resolver_factory_mojo_unittest. Also use some std::move isntead of Pass(). BUG=554289 Committed: https://crrev.com/6a847e3597891af23b78ef4088d19f1a773d7e69 Cr-Commit-Position: refs/heads/master@{#364007}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M net/proxy/proxy_resolver_factory_mojo_unittest.cc View 6 chunks +13 lines, -10 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
Olli Raula
Could you review?
5 years ago (2015-12-08 09:08:32 UTC) #3
eroman
lgtm https://codereview.chromium.org/1509513002/diff/1/net/proxy/proxy_resolver_factory_mojo_unittest.cc File net/proxy/proxy_resolver_factory_mojo_unittest.cc (left): https://codereview.chromium.org/1509513002/diff/1/net/proxy/proxy_resolver_factory_mojo_unittest.cc#oldcode441 net/proxy/proxy_resolver_factory_mojo_unittest.cc:441: new interfaces::ProxyResolverFactoryRequestClientPtr(client.Pass())); strictly speaking these changes from .Pass() ...
5 years ago (2015-12-08 19:50:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509513002/1
5 years ago (2015-12-09 07:12:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 08:31:06 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 08:32:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a847e3597891af23b78ef4088d19f1a773d7e69
Cr-Commit-Position: refs/heads/master@{#364007}

Powered by Google App Engine
This is Rietveld 408576698