Issue 15095015: Revert 200603 "Make Windows traversal checking handle pathologic..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15095015: Revert 200603 "Make Windows traversal checking handle pathologic..." (Closed)

Created:
7 years, 7 months ago by please use gerrit instead

Modified:
7 years, 7 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 200603 "Make Windows traversal checking handle pathologic..." Seems to have broken base_unittests on Linux ASAN. > Make Windows traversal checking handle pathological cases > > Different versions of Windows have undocumented quirks in handling path components > (e.g. truncating or ignoring certain leading or trailing characters). In order to avoid potential > security bugs we're going to treat components more loosely and risk a few unlikely false > positives from FilePath::ReferencesParent(). > > BUG=181617 > R=brettw@chromium.org, ericu@chromium.org > > Review URL: https://codereview.chromium.org/12771015 TBR=jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200610

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -16 lines)			Patch
M	trunk/src/base/files/file_path.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	trunk/src/base/files/file_path_unittest.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/webkit/fileapi/sandbox_mount_point_provider_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

7 years, 7 months ago (2013-05-16 19:46:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r200610.

Expand Messages | Collapse Messages