Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 1509493003: [Android] Fix environment variable handling in devil_env. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: windows-friendly environment initialization Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/adb_command_line.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 devil_test_env = dict(pylib_test_env) 64 devil_test_env = dict(pylib_test_env)
65 devil_test_env.update({ 65 devil_test_env.update({
66 'DEVIL_ENV_CONFIG': 66 'DEVIL_ENV_CONFIG':
67 input_api.os_path.join(build_android_dir, 'devil_chromium.json') 67 input_api.os_path.join(build_android_dir, 'devil_chromium.json')
68 }) 68 })
69 output.extend(input_api.canned_checks.RunUnitTests( 69 output.extend(input_api.canned_checks.RunUnitTests(
70 input_api, 70 input_api,
71 output_api, 71 output_api,
72 unit_tests=[ 72 unit_tests=[
73 J('devil', 'devil_env_test.py'),
73 J('devil', 'android', 'battery_utils_test.py'), 74 J('devil', 'android', 'battery_utils_test.py'),
74 J('devil', 'android', 'device_utils_test.py'), 75 J('devil', 'android', 'device_utils_test.py'),
75 J('devil', 'android', 'fastboot_utils_test.py'), 76 J('devil', 'android', 'fastboot_utils_test.py'),
76 J('devil', 'android', 'md5sum_test.py'), 77 J('devil', 'android', 'md5sum_test.py'),
77 J('devil', 'android', 'logcat_monitor_test.py'), 78 J('devil', 'android', 'logcat_monitor_test.py'),
78 J('devil', 'utils', 'cmd_helper_test.py'), 79 J('devil', 'utils', 'cmd_helper_test.py'),
79 J('devil', 'utils', 'timeout_retry_unittest.py'), 80 J('devil', 'utils', 'timeout_retry_unittest.py'),
80 ], 81 ],
81 env=devil_test_env)) 82 env=devil_test_env))
82 return output 83 return output
83 84
84 85
85 def CheckChangeOnUpload(input_api, output_api): 86 def CheckChangeOnUpload(input_api, output_api):
86 return CommonChecks(input_api, output_api) 87 return CommonChecks(input_api, output_api)
87 88
88 89
89 def CheckChangeOnCommit(input_api, output_api): 90 def CheckChangeOnCommit(input_api, output_api):
90 return CommonChecks(input_api, output_api) 91 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | build/android/adb_command_line.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698