Disallow [Measure] and [MeasureAs] on interfaces without a constructor

Disallow [Measure] and [MeasureAs] on interfaces without a constructor

For the instances where MeasureAs was specified on interfaces without
a constructor, simply remove the MeasureAs. Since they can't be
created by script, it seems more worthwhile want to measure where
these object are returned rather than the use of the interfaces
themselves.

The only change in generated code will be less includes of
core/frame/UseCounter.h, as can be seen in the binding testsuite
update.

BUG=415074, 567015
Committed: https://crrev.com/ec4fb75106a96b90facdcfe0a762d65d6c066c84
Cr-Commit-Position: refs/heads/master@{#363503}

[davve, 2015-12-07 14:47:49]

davve@opera.com changed reviewers:
+ fs@opera.com, haraken@chromium.org

[davve, 2015-12-07 14:47:49]

+haraken for bindings, +philipj for the rest. PTAL.

[davve, 2015-12-07 14:48:22]

On 2015/12/07 14:47:49, David Vest wrote:
> +haraken for bindings, +philipj for the rest. PTAL.

And by philipj, I meant fs. :)

[fs, 2015-12-07 14:50:27]

On 2015/12/07 at 14:48:22, davve wrote:
> On 2015/12/07 14:47:49, David Vest wrote:
> > +haraken for bindings, +philipj for the rest. PTAL.
> 
> And by philipj, I meant fs. :)

core/svg LGTM

[haraken, 2015-12-07 14:51:38]

LGTM

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl (left):

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl:31: MeasureAs=SVG1DOM,

What has this been counting before this CL?

[davve, 2015-12-07 14:53:13]

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl (left):

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl:31: MeasureAs=SVG1DOM,
On 2015/12/07 14:51:38, haraken wrote:
> 
> What has this been counting before this CL?

Nothing, as far as I can tell.

[haraken, 2015-12-07 14:55:58]

On 2015/12/07 14:53:13, David Vest wrote:
>
https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl (left):
> 
>
https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl:31: MeasureAs=SVG1DOM,
> On 2015/12/07 14:51:38, haraken wrote:
> > 
> > What has this been counting before this CL?
> 
> Nothing, as far as I can tell.

Great refactoring :)

[davve, 2015-12-07 14:57:16]

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl (left):

https://codereview.chromium.org/1509493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl:31: MeasureAs=SVG1DOM,
On 2015/12/07 14:53:12, David Vest wrote:
> On 2015/12/07 14:51:38, haraken wrote:
> > 
> > What has this been counting before this CL?
> 
> Nothing, as far as I can tell.

gen/blink/bindings/core/v8/V8SVGAnimatedAngle.cpp has before this patch only one
mention of UseCounter:

#include "core/frame/UseCounter.h"

No actual counting.

[davve, 2015-12-07 14:58:19]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2015-12-07 14:59:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509493002/1

[commit-bot: I haz the power, 2015-12-07 16:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 16:20:18]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davve, 2015-12-07 16:22:06]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2015-12-07 16:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1509493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1509493002/1

[commit-bot: I haz the power, 2015-12-07 17:22:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-07 17:23:48]

Description was changed from

==========
Disallow [Measure] and [MeasureAs] on interfaces without a constructor

For the instances where MeasureAs was specified on interfaces without
a constructor, simply remove the MeasureAs. Since they can't be
created by script, it seems more worthwhile want to measure where
these object are returned rather than the use of the interfaces
themselves.

The only change in generated code will be less includes of
core/frame/UseCounter.h, as can be seen in the binding testsuite
update.

BUG=415074, 567015
==========

to

==========
Disallow [Measure] and [MeasureAs] on interfaces without a constructor

For the instances where MeasureAs was specified on interfaces without
a constructor, simply remove the MeasureAs. Since they can't be
created by script, it seems more worthwhile want to measure where
these object are returned rather than the use of the interfaces
themselves.

The only change in generated code will be less includes of
core/frame/UseCounter.h, as can be seen in the binding testsuite
update.

BUG=415074, 567015

Committed: https://crrev.com/ec4fb75106a96b90facdcfe0a762d65d6c066c84
Cr-Commit-Position: refs/heads/master@{#363503}
==========

[commit-bot: I haz the power, 2015-12-07 17:23:50]

Patchset 1 (id:??) landed as
https://crrev.com/ec4fb75106a96b90facdcfe0a762d65d6c066c84
Cr-Commit-Position: refs/heads/master@{#363503}