Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1509443003: Add SK_IGNORE_GL_TEXTURE_TARGET to SkUserConfig.h (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_IGNORE_GL_TEXTURE_TARGET to SkUserConfig.h This will allow an atomic change that makes Chrome use the new GrGLTextureInfo object and undefines this macro. Currently the macro is defined in a gyp file in the skia repository on behalf of Chrome. BUG=551072 Committed: https://crrev.com/229b1db0ba46a2b3d82b0acfecd13702f0725996 Cr-Commit-Position: refs/heads/master@{#363583}

Patch Set 1 #

Patch Set 2 : guard with ifndef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
bsalomon
5 years ago (2015-12-07 19:47:17 UTC) #2
reed1
lgtm
5 years ago (2015-12-07 19:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509443003/20001
5 years ago (2015-12-07 19:57:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 21:11:52 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-07 21:13:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/229b1db0ba46a2b3d82b0acfecd13702f0725996
Cr-Commit-Position: refs/heads/master@{#363583}

Powered by Google App Engine
This is Rietveld 408576698