Issue 150943004: A64: Remove incorrect ASSERT From DoStoreKeyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150943004: A64: Remove incorrect ASSERT From DoStoreKeyed (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Remove incorrect ASSERT From DoStoreKeyed BUG=none R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19262

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/a64/lithium-a64.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

PTAL https://codereview.chromium.org/150943004/diff/1/src/a64/lithium-a64.cc File src/a64/lithium-a64.cc (right): https://codereview.chromium.org/150943004/diff/1/src/a64/lithium-a64.cc#newcode2088 src/a64/lithium-a64.cc:2088: ASSERT((instr->is_fixed_typed_array() && this is the correct ASSERT

6 years, 10 months ago (2014-02-10 20:56:06 UTC) #1

jochen (gone - plz use gerrit)

Committed patchset #1 manually as r19262 (presubmit successful).

6 years, 10 months ago (2014-02-11 09:26:32 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages