Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 150943002: Split GrUnitTests.cpp into two separate unit tests. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
brian1, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Split GrUnitTests.cpp into two separate unit tests. GrUnitTests is too generic. Instead we split this file between the two APIs being tested there, GrTBSearch and GrBinHashKey. BUG=None TEST=tests -m GrTBSearchTest && tests -m GrBinHashKeyTest R=brian@thesalomons.net, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -108 lines) Patch
M gyp/tests.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTBSearch.h View 2 chunks +2 lines, -3 lines 0 comments Download
A + tests/GrBinHashKeyTest.cpp View 2 chunks +3 lines, -33 lines 0 comments Download
A tests/GrTBSearchTest.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
D tests/GrUnitTests.cpp View 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
6 years, 10 months ago (2014-01-30 23:56:45 UTC) #1
brian1
lgtm
6 years, 10 months ago (2014-01-31 03:26:43 UTC) #2
tfarina
6 years, 10 months ago (2014-01-31 21:49:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698