src/builtins.cc - Issue 15094018: Create AllocationSite objects, pointed to by AllocationSiteInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 15094018: Create AllocationSite objects, pointed to by AllocationSiteInfo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Comment response Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index f4ebdc2a3e55139cb72fcaf063a235a347de4e7f..d17137f2289f8a82326fef5953de930dbff9be94 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -212,8 +212,9 @@ static MaybeObject* ArrayCodeGenericCommon(Arguments* args,

if (maybe_array->IsFailure()) return maybe_array;

AllocationSiteInfo* info = AllocationSiteInfo::FindForJSObject(array);

- ElementsKind to_kind = array->GetElementsKind();

- if (info != NULL && info->GetElementsKindPayload(&to_kind)) {

+ if (info != NULL && info->IsValid()) {

+ AllocationSite* site = info->GetAllocationSite();

+ ElementsKind to_kind = site->GetElementsKindPayload();

if (IsMoreGeneralElementsKindTransition(array->GetElementsKind(),

to_kind)) {

// We have advice that we should change the elements kind

« no previous file with comments | « src/ast.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »